After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 496006 - pygobject-2.14.0 picks up binary dependency on libffi
pygobject-2.14.0 picks up binary dependency on libffi
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: general
2.14.x
Other Linux
: Normal major
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
: 482788 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-11-12 00:21 UTC by Ed Catmur
Modified: 2008-03-02 13:34 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22

Attachments
libffi.patch (1.02 KB, patch)
2007-11-12 00:23 UTC, Ed Catmur 		none Details | Review
libffi.patch (1.01 KB, patch)
2007-11-12 07:25 UTC, Ed Catmur 		none Details | Review
libffi.patch (1.39 KB, patch)
2007-12-27 11:19 UTC, Ed Catmur 		committed Details | Review

Description Ed Catmur 2007-11-12 00:21:27 UTC 
From http://bugs.gentoo.org/show_bug.cgi?id=198870

...
checking pkg-config is at least version 0.7... yes
checking for GLIB - version >= 2.8.0... yes (version 2.14.3)
checking for ffi.h... yes
...
libffi support: yes

This introduces a link dependency on -lffi, and can break the build (c.f. Gentoo bug 194632).

libffi dependency should be explicitly enabled by a --enable-ffi configure flag.
Comment 1 Ed Catmur 2007-11-12 00:21:53 UTC 
Hm - possibly related to bug 482788.
Comment 2 Ed Catmur 2007-11-12 00:23:34 UTC 
Created attachment 98947 [details] [review]
libffi.patch

configure patch.
Comment 3 Ed Catmur 2007-11-12 07:25:16 UTC 
Created attachment 98962 [details] [review]
libffi.patch

improve patch
Comment 4 Johan (not receiving bugmail) Dahlin 2007-11-12 07:54:51 UTC 
*** Bug 482788 has been marked as a duplicate of this bug. ***
Comment 5 Ed Catmur 2007-12-27 11:19:26 UTC 
Created attachment 101665 [details] [review]
libffi.patch

Updated patch, moves configure flag to --with-libffi to allow passing in linker flags (e.g. on Gentoo, --with-libffi=-L/usr/lib/libffi).  Uses AC_SEARCH_LIBS to ensure libffi can be linked in.
Comment 6 Johan (not receiving bugmail) Dahlin 2007-12-27 11:24:04 UTC 
(In reply to comment #0)
> From http://bugs.gentoo.org/show_bug.cgi?id=198870
> 

> libffi dependency should be explicitly enabled by a --enable-ffi configure
> flag.
> 

I disagree with this, libffi should be enabled by default. Either the configure has to be fixed to do proper detection or gentoo has to fix it's copy of libffi.
Comment 7 Ed Catmur 2007-12-27 12:32:28 UTC 
(In reply to comment #6)
> I disagree with this, libffi should be enabled by default. Either the configure
> has to be fixed to do proper detection or gentoo has to fix it's copy of
> libffi.

Attached patch does automagic detection if --with-libffi or --without-libffi not given.
Comment 8 Johan (not receiving bugmail) Dahlin 2008-01-11 21:41:49 UTC 
2008-01-11  Johan Dahlin  <johan@gnome.org>

	* configure.ac: Don't link against libffi if we cannot find libffi
	on the system. (#496006, Ed Catmur)
Comment 9 Gilles Dartiguelongue 2008-03-02 13:34:20 UTC 
fixing patch status