After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 495716 - [patch] use scrollwheel to change scale in image preview
[patch] use scrollwheel to change scale in image preview
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
2.21.x
Other Linux
: Normal normal
: GNOME3.4
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-11-10 21:37 UTC by Claudio Saavedra
Modified: 2012-01-04 20:19 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
patch (5.28 KB, patch)
2007-11-10 21:39 UTC, Claudio Saavedra
none Details | Review

Description Claudio Saavedra 2007-11-10 21:37:40 UTC
Here's a patch to enable the usage of the scrollwheel in the EogPrintPreview to change the scale of the printed image.

[patch generated during a live tutorial in Puerto Montt. Puerto Montt rules!]
Comment 1 Claudio Saavedra 2007-11-10 21:39:24 UTC
Created attachment 98892 [details] [review]
patch

Here is the initial patch. We could also use +/- keys to change the scale. That's pending.
Comment 2 Felix Riemann 2007-11-11 10:37:06 UTC
Works pretty nice so far. :-)
There are two "bugs" I noticed:

1. When I open the dialog and try to enlarge it with the scrollwheel (that shouldn't work as the image is already made to fit to the page) the image is enlarged above the print border to the page border. The scrollwheeel is not working anymore after that until I scaled it down again with the slider.

2. When I enlarge the image after having it scaled down I get warnings once I hit maximum:
(eog:24027): GLib-GObject-WARNING **: value "nan" of type `gfloat' is invalid or out of range for property `image-x-align' of type `gfloat'
Comment 3 Felix Riemann 2012-01-04 20:19:22 UTC
Finally committed it, slightly refactored it and added the necessary callback to work with the +/- keys (although one doesn't see the focus rectangle currently). :)

commit 982a69b0888fc5d0ac3427166aa5cca30b0e97b4
Author: Felix Riemann <>
Date:   Wed Jan 4 21:08:27 2012 +0100

    Extend print preview to scale with plus and minus from keyboard as well
    
    https://bugzilla.gnome.org/show_bug.cgi?id=495716

commit a7a1cde3fb2d13214b0dd30595d652868ff118af
Author: Claudio Saavedra <>
Date:   Wed Jan 4 17:40:41 2012 +0100

    Make it possible to scale the print preview using the scrollwheel
    
    https://bugzilla.gnome.org/show_bug.cgi?id=495716


This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.