GNOME Bugzilla – Bug 495320
GtkRange does not use gdk_event_request_motions
Last modified: 2009-02-25 17:39:24 UTC
As noted in the docs[1], widgets using motion hints should be using gdk_event_request_motions now. The attached patch gets the x, y coordinates from the event instead of doing another roundtrip for them, not sure if that's ok or not... [1]:http://library.gnome.org/devel/gdk/stable/gdk-Events.html#id2743065
Created attachment 98826 [details] [review] Use-gdk_event_request_motions-for-GtkRange.patch Subject: [PATCH] Use gdk_event_request_motions for GtkRange. --- gtk/gtkrange.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)
Makes sense. Do you need the casts at all, or even the local (x, y) variables? (I.e. can't you just do range->layout->mouse_x = event->x and use that throughout the rest of the function?) Go ahead and commit :)
Thanks, committed in trunk with those changes.