GNOME Bugzilla – Bug 494425
'Save All' handles duplicate attachement names incorrectly
Last modified: 2007-11-23 09:26:55 UTC
Please describe the problem: When an email contains multiple attachments with the same filename (eg: licence.txt), selecting 'Save All' saves each attachment overtop of the previous one, resulting in only the last attachment being saved. No error message is produced. Steps to reproduce: 1. Create an email with multiple attachments having the same filename 2. Select 'Save all' when viewing the email, to save all of the attachments Actual results: Only the last attachment is successfully saved. Expected results: Either an error message, a dialogue, or versioning the files (eg: licence.txt_1) Does this happen every time? Yes. Other information:
Downstream bug for this: https://bugzilla.redhat.com/show_bug.cgi?id=335451
Created attachment 99472 [details] [review] proposed evo patch for evolution; It will rename duplicate file names, if any, in the way to keep extension, if exists, otherwise just append "(#)" at the end of file name. The first occurrence will keep original name. I'm not sure if rename also when saving only one attachment, to keep "consistent", so this patch doesn't do that.
Just one observation (list-append to prepend+reverse could be better) Othewise commit to head/stable
Committed to trunk. Committed revision 34568. Committed to stable. Committed revision 34569. The only difference between attached patch and committed changes is that I did it with prepend and reverse functions.