GNOME Bugzilla – Bug 494415
Behaviour of an account's "make this my default acocunt" checkbox is confusing
Last modified: 2012-03-02 13:07:22 UTC
Please describe the problem: The "make this my default account" checkbox is confusing. If an account is already the default account, it is not initially checked when the account is edited. Instead, I think the checkbox should be selected, and also disabled. Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information: It might be better to get rid of the checkbox altogether... the default account can already be set from the preferences window, by means of the 'Default' button.
Created attachment 98932 [details] [review] evolution-edit-account-dialog.patch ChangeLog | 7 +++++++ em-account-editor.c | 12 +++++++----- 2 files changed, 14 insertions(+), 5 deletions(-) I'm not sure of what was wrong in the logic because I worked on this back in july but as far as my testing goes, this patch should fix it.
I see little coding style issue near 'mail_config_get_account_by_name', put space after that. You removed from there too much, I'm afraid, look at comment above second occurrence of "default_flagged" string in that source file and also, when I add new account and check there this checkbox, then it will not appear as default account when storing this one, but without this patch it works.
I think I agree with Sam about just getting rid of the checkbox altogether. Either way, let's also make the default setting more pronounced on the account list by using "emblem-default" both in the Default button and next to the default account name (instead of "[Default]", which is easy to miss). CC'ing Srini for his thoughts.
Still valid in 3.2.3
*** This bug has been marked as a duplicate of bug 330213 ***