After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 494171 - Send/receive dialog cut off
Send/receive dialog cut off
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.22.x (obsolete)
Other Linux
: Low enhancement
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
: 541994 557467 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-11-06 14:19 UTC by Michael Monreal
Modified: 2008-10-22 18:26 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
Shot (45.14 KB, image/png)
2007-11-06 14:24 UTC, Michael Monreal
  Details
Proposed patch (52.37 KB, patch)
2008-01-22 05:53 UTC, Matthew Barnes
reviewed Details | Review
save send receive dialog size to gconf (4.83 KB, patch)
2008-04-22 07:45 UTC, Lucian Langa
none Details | Review
Final patch (3.57 KB, patch)
2008-04-22 15:15 UTC, Matthew Barnes
committed Details | Review

Description Michael Monreal 2007-11-06 14:19:36 UTC
This problem could be solved by the proposal in bug 360614, but I don't know how likely that is to ever get implemented... So for the time being:

If you have more than 3 accounts that fetch/send mail, the send/receive dialog will get a scrollweel and only show the first three. The window could expand to the required size... I suppose more than 6 or 7 accounts is not very common, so it could be limited at some point (same height as width?) but until then, it shoudl expand to fit all the accounts in.
Comment 1 Michael Monreal 2007-11-06 14:24:16 UTC
Created attachment 98663 [details]
Shot
Comment 2 André Klapper 2007-11-06 15:21:15 UTC
i think matthew will implement saving the window size after a manual resize to gconf for evolution 2.22
Comment 3 Michael Monreal 2007-11-06 16:50:41 UTC
Not really what I was thinking about but that would help, too.
Comment 4 Miguel 2008-01-20 11:20:46 UTC
I can confirm the bug. Every time I click send and receive the window will be the same size, not showing all of my accounts. I have to manually resize it, but the new size won't be saved for the next time I Send and Receive email.
Comment 5 André Klapper 2008-01-20 14:49:04 UTC
i wonder if matthew has a patch handy that stores the send/receive dialog window size to some gconf key?
Comment 6 Matthew Barnes 2008-01-20 16:26:04 UTC
This can easily be done with OpenedHand's GConfBridge.  I've already proposed embedding the GConfBridge sources -- all two files -- into Evolution until GNOME comes up with a better configuration system.  It's not worth writing out the whole save-widget-dimensions-using-delayed-writes pattern again by hand.

I'll put together a patch.
Comment 7 Matthew Barnes 2008-01-22 05:53:14 UTC
Created attachment 103402 [details] [review]
Proposed patch

With GConfBridge, this is stupid simple.
Comment 8 Srinivasa Ragavan 2008-01-24 04:12:44 UTC
Matt, we have discussed this before. I wouldn't be interested to take it unless we get a tangible benefit out of it. Not too late surely. I think we do it the same way in every other place, we can do it here also. (get/set the window sizes to GConf). We can look at GConfBridge later. Hope you understand my point.
Comment 9 Matthew Barnes 2008-03-11 00:37:13 UTC
Bumping version to a stable release.
Comment 10 André Klapper 2008-04-04 10:12:26 UTC
this is starting to annoy me. can we find a short-term solution (e.g. the one proposed in comment #8) for 2.23.x, please?
i don't want to patch it every time by adding a	gtk_widget_set_size_request(send_recv_dialog, 600, 600) to the code...
Comment 11 Matthew Barnes 2008-04-04 13:19:30 UTC
Someone else can take this bug if GConfBridge is still not permitted.  The patch in comment #7 works, is simple, and the same approach can be applied throughout Evolution where we want persistent window sizes and/or positions.  I'm not interested in hand-writing the same signal handlers and timeout logic over and over.
Comment 12 Lucian Langa 2008-04-22 07:45:47 UTC
Created attachment 109672 [details] [review]
save send receive dialog size to gconf
Comment 13 Lucian Langa 2008-04-22 07:46:02 UTC
here's a patch that implements dialog resize signal and restores dialog size from gconf. For schema modification I took over schema that Matthew proposed.
Comment 14 Matthew Barnes 2008-04-22 15:15:30 UTC
Created attachment 109694 [details] [review]
Final patch

Srini agreed to let me use GConfBridge in Evolution.  The GConfBridge is already in trunk, so here's the final patch I'm committing for this bug.

Committed to trunk (revision 35400).
Comment 15 Milan Crha 2008-04-25 11:13:54 UTC
Does it mean we can get rid of all "remember window position" bugs with the same approach as here? Maybe only with one exception, I do not want to bump scheme files with such crap, it doesn't worth it, really. Maybe if it will be saved under reasonable gconf key, then it would be fine. I think we can keep the size request, and let the GConfBridge does its job just after that, so it will be better than relay on the default keys. (It scared me a bit, when I saw only dots instead of account names there, because the scheme file failed to install.)
Comment 16 Matthew Barnes 2008-04-25 12:08:51 UTC
Would be nice.  I've already filed bug #529565 to take care of the places where we already save window sizes and pane positions.

Keeping default window sizes in the GConf schema will work fine for users running a proper release.  I think the behavior you saw was because the schema was never loaded into your GConf daemon after you installed from SVN, so the default window sizes never got loaded.
Comment 17 Milan Crha 2008-04-25 12:43:52 UTC
Oh, "proper release", what's that? :) You know, you can compile from official stable tarballs, but it will not work for you too, somehow.
Comment 18 Matthew Barnes 2008-07-08 14:07:02 UTC
*** Bug 541994 has been marked as a duplicate of this bug. ***
Comment 19 Matthew Barnes 2008-10-22 18:26:49 UTC
*** Bug 557467 has been marked as a duplicate of this bug. ***