After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 493647 - Add Option to filter out apps with 0 children
Add Option to filter out apps with 0 children
Status: RESOLVED FIXED
Product: accerciser
Classification: Applications
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Accerciser Developers
Accerciser Developers
Depends on:
Blocks:
 
 
Reported: 2007-11-05 08:51 UTC by SteveLee
Modified: 2012-02-20 01:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Adding option for hiding/showing accessibles with 0 children (12.57 KB, patch)
2011-07-15 15:02 UTC, Aline Bessa
reviewed Details | Review

Description SteveLee 2007-11-05 08:51:19 UTC
in Gutsy I get a bunch of apps in the tree with 0 children
and looking at them they're probably of very limited interest.

Can we have an option to filter them out?
Comment 1 Joanmarie Diggs (IRC: joanie) 2011-07-11 23:42:44 UTC
Hey Steve!

This bug was just pointed out to me. Are you still seeing this issue and is it a problem? Gutsy, of course, was a long time ago. And we now have AT-SPI2, etc.

FWIW, I rarely see apps with 0 children. Nor would they get in my way unless there were bunches and bunches.

Thoughts and/or updates? Thanks!
Comment 2 Javier Hernández 2011-07-14 10:53:08 UTC
Joanie, yes, I can confirm that we still have apps without children in our accessible treeview, so, IMHO, an option to filter them could be very usefull for most of developers (like me :P)

So, patches are welcome! ;)

Regards!
Comment 3 Aline Bessa 2011-07-14 11:47:24 UTC
Ok, I'm working on one and will send it asap. ;)
Comment 4 Javier Hernández 2011-07-14 11:51:38 UTC
Great! Thanks!! ;)
Comment 5 Joanmarie Diggs (IRC: joanie) 2011-07-14 13:40:31 UTC
I think the option then should indeed be an option rather than the only behavior. I would argue it should not be the default behavior either.

I think that someone using Accerciser might want to know what apps have been successfully registered but which have no children.

Similarly, one might wish to know when an app has gotten rid of its last child, but has not terminated (at least as far as the registry is concerned). If it just suddenly vanishes from the tree, that is not ideal.

Likewise, if an app only were to appear when it had children, we no longer know if it only just registered, or if it registered long ago but only now has children.

In summary, knowing what apps have 0 children and when they kill their last child and add their first, can be valuable information for those of us developing assistive technologies. And unless there is a crazy amount of these children, I see no reason for filtering them out.

For what it's worth....
Comment 6 Aline Bessa 2011-07-15 15:02:44 UTC
Created attachment 192034 [details] [review]
Adding option for hiding/showing accessibles with 0 children

There goes a patch for it. The option is under the View tab and is called Hide/show leaves (leaves == accs without children). 

If you're hiding the leaves and a new accessible appears, you'll notice it'll take a while to be inserted in the tree. This is why while the accessible is loading their children, it can be confused with a leaf (it has 0 children **before** loading their children). To avoid this confusing situation, I added a sleep(ACCESSIBLE_LOADING) that makes the accessible wait for a moment until be inserted. 

It would be awesome if you could test it and/or give me more suggestions about it.
Comment 7 Javier Hernández 2012-02-20 01:30:18 UTC
Hi!

The patch is awesome, so thanks!

I changed the menu entry text and did some slightly modifications.

The patch has arrived the master. see commit: 	408d71dba1344c3ff0ffbf2d64a3d67c5c8b1b26

Best regards!
Comment 8 Javier Hernández 2012-02-20 01:33:52 UTC
Review of attachment 192034 [details] [review]:

Review