After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 492949 - screensavers-personal-slideshow should not show hidden directories
screensavers-personal-slideshow should not show hidden directories
Status: RESOLVED FIXED
Product: gnome-screensaver
Classification: Deprecated
Component: general
2.20.x
Other All
: Normal normal
: ---
Assigned To: gnome-screensaver maintainers
gnome-screensaver maintainers
Depends on:
Blocks:
 
 
Reported: 2007-11-03 08:14 UTC by Sebastian Breier
Modified: 2008-12-03 02:33 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20


Attachments
compare the first letter of each file with '.' (1.13 KB, patch)
2008-11-24 23:29 UTC, Jörg
none Details | Review

Description Sebastian Breier 2007-11-03 08:14:30 UTC
Last time the screensavers-personal-slideshow ran (a screensaver that shows pictures from "~/Bilder", which is something like "~/Pictures" in English), I saw some pictures that I don't really want people to see; This was the first time I became aware of the existence of this screensaver. The images that were shown lie in a hidden directory in my images folder.

I request that this screensaver doesn't traverse hidden directories when looking for images to show. Hidden directories are hidden for a reason. :-)
Comment 2 Pedro Villavicencio 2007-11-05 16:47:14 UTC
Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.


*** This bug has been marked as a duplicate of 481090 ***
Comment 3 Teppo Turtiainen 2007-12-08 19:32:58 UTC
This is actually not a duplicate of bug 481090. Bug 481090 is about showing all images in $HOME, this is about showing images in hidden folders under $HOME/Pictures. I am not able to reproduce bug 481090 with gnome-screensaver 2.20.0 on Ubuntu Gutsy, but I am able to reproduce this.
Comment 4 William Jon McCann 2008-11-13 15:37:26 UTC
Anyone have a patch for this?
Comment 5 Jörg 2008-11-24 23:29:24 UTC
Created attachment 123350 [details] [review]
compare the first letter of each file with '.'
Comment 6 William Jon McCann 2008-12-03 02:33:31 UTC
Committed this with a change to make the hidden case a shortcut out instead of indenting the entire block.  Thanks.