GNOME Bugzilla – Bug 492702
New Mail notify code and preferences UI movement
Last modified: 2013-09-13 00:59:11 UTC
Currently Account preferences tab of mailer is very congested. Some proposed changes for this is : + Move the code for new mail notify into plugins/new-mail-notify. + Move the New Mail Notification Preferences UI to plugins configure tab. + Include [Bug 246431] Add the possibility to preview the sound used for mail notification in this movement.
Also consider folding the "New Mail Notification" plugin into the "Mail Notification" plugin. The "New Mail Notification" plugin emits a D-Bus message when new mail arrives. We should have a single plugin for customizing new mail notification.
#246431 has to be included with this work.
Created attachment 100507 [details] [review] proposed evo patch for evolution; Here we go. The only thing which is not included is a remove of new-mail-notification plugin from svn and Makefile... and configure.in and so on. It is easier to test it without this remove and do the remove in time of commit. The patch contains all what I thought it should, it also contains the "Play" button for sound part. (I will, when committed, mark the second bug as fixed with the note about this bug.)
TODO: a) remove plugins/new-mail-notify b) remove it from configure.in c) remove files under plugins/new-mail-notify from po/POTFILES.in anything else?
Basic code looks fine. I will do that testing and revert back. Johnny can you do a independent testing/review ?
Looks good to me.
Patch committed in svn trunk rev 34702. Keeping the bug open till 'todos' are done. Some work needs to be done in configure.in .
Johnny list todos please. Also make sure that the obsolete plugin should be off the source.
(In reply to comment #4) > TODO: > a) remove plugins/new-mail-notify > b) remove it from configure.in > c) remove files under plugins/new-mail-notify from po/POTFILES.in d) make dbus part of the plugin optional based on the present of dbus libs
Created attachment 102455 [details] [review] Proposed patch
a) You know, ChangeLog entry ;) b) Just do not name it "New Mail Notify plugin" in configure.in, but "Mail Notification plugin" instead, so it will not be confusing. Maybe add there a 'DBUS part" words too? c) There left one "plugins/new-mail-notify/Makefile" line in configure.in. Apart of these little things it works fine. Thanks for help, srag.
Yep. Thx. Committed to trunk. Sending ChangeLog Sending configure.in Sending plugins/mail-notification/ChangeLog Sending plugins/mail-notification/Makefile.am Sending plugins/mail-notification/mail-notification.c Deleting plugins/new-mail-notify Sending po/ChangeLog Sending po/POTFILES.in Transmitting file data ....... Committed revision 34784.