GNOME Bugzilla – Bug 491722
[playbin] regression: crash with external subtitles
Last modified: 2007-11-06 11:10:19 UTC
Trying to use playbin with external subtitles crashes for me with CVS:
gst-launch-0.10 playbin uri=file:///path/foo.avi suburi=file:///path/foo.srt
in queue_threshold_reached() because get_active_group() returns NULL.
Everything works fine if I add a simple if(!group)return , but that doesn't look like the right solution.
I wonder if queue_threshold_reached() should have been called at all given that group_commit() has already been called via no_more_pads_full() from new_decoded_pad_full().
I also wonder if queue_threshold_reached() shouldn't take the group lock before calling _get_active_group()?
This seems to have been caused by the patch in bug #465015.
Created attachment 98568 [details] [review]
hack around the problem
I believe you. Patch looks good to me
2007-11-06 Tim-Philipp Müller <tim at centricular dot net>
* gst/playback/gstplaybasebin.c: (queue_threshold_reached),
Avoid crash when there are external subtitles (fixes #491722).