GNOME Bugzilla – Bug 490672
Popup management is broken
Last modified: 2007-11-17 20:44:53 UTC
Moved hidden-popup-count and popups-allowed properties to EphyEmbed. They use EphyWindow, so they are disabled until we refactor them to not use the epiphany frontend.
Yep, confirmed. And also most of the ephy extensions that depend on ephytab signals are now useless.
Extensions are fixed now. I don't recall about popups but middle clicks are broken.
Created attachment 99251 [details] [review] [1/1] Re-enable popup management code in EphyBaseEmbed. Plus a small bugfix in MozillaEmbed about GtkMozembed vs. EphyEmbed confusion. --- embed/ephy-base-embed.c | 618 +++++++++++++++++++-------------------- embed/ephy-base-embed.h | 3 + embed/mozilla/mozilla-embed.cpp | 8 +- 3 files changed, 312 insertions(+), 317 deletions(-)
+ popup = g_new0 (PopupInfo, 1); Let's use gslice here. + popup->url = (url == NULL) ? NULL : g_strdup (url); g_strdup is NULL-safe.
Created attachment 99257 [details] [review] [1/1] Put visibility property into EphyBaseEmbed, we need it for popups. embed/ephy-base-embed.c | 33 +++++++++++++++++++++++++++++++++ embed/ephy-base-embed.h | 2 ++ embed/ephy-embed.c | 16 ++++++++++++++++ embed/ephy-embed.h | 2 ++ embed/mozilla/mozilla-embed.cpp | 14 ++++++++++++++ src/ephy-window.c | 19 +++++++++++++++++++ 6 files changed, 86 insertions(+), 0 deletions(-)
Committed, thanks. We need to put the size-to code in the backend (gecko) to get the right sizes for the popups.
Created attachment 99260 [details] [review] [1/1] Move size-to code to the gecko backend. embed/mozilla/mozilla-embed.cpp | 137 +++++++++++++++++++++++++++++++++++++++ src/ephy-window.c | 75 +--------------------- 2 files changed, 138 insertions(+), 74 deletions(-)
All committed, closing.