After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 490521 - [pwg] caps negotiation docs need updating
[pwg] caps negotiation docs need updating
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: documentation
git master
Other Linux
: Normal normal
: 1.0.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-10-26 13:51 UTC by Thijs Vermeir
Modified: 2012-09-28 18:03 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22

Attachments
patch for this typo (630 bytes, patch)
2007-10-26 13:53 UTC, Thijs Vermeir 		none Details | Review
patch from the root dir (657 bytes, patch)
2007-10-26 13:55 UTC, Thijs Vermeir 		needs-work Details | Review

Description Thijs Vermeir 2007-10-26 13:51:54 UTC 
I think the pad is wrong in the example of the caps negotiation in the second example: 
...
  if (gst_pad_set_caps (filter->sinkpad, caps)) {
    filter->passthrough = TRUE;
  } else {
...
must be:
...
  if (gst_pad_set_caps (filter->srcpad, caps)) {
    filter->passthrough = TRUE;
  } else {
...

http://gstreamer.freedesktop.org/data/doc/gstreamer/head/pwg/html/section-nego-downstream.html
Comment 1 Thijs Vermeir 2007-10-26 13:53:41 UTC 
Created attachment 97919 [details] [review]
patch for this typo
Comment 2 Thijs Vermeir 2007-10-26 13:55:27 UTC 
Created attachment 97920 [details] [review]
patch from the root dir
Comment 3 Wim Taymans 2007-10-29 11:04:58 UTC 
That example is completely outdated, this is not how 0.10 capsnego works at all.
Comment 4 Thijs Vermeir 2007-11-11 15:55:58 UTC 
If that information is wrong/outdated, we better update or remove it ...
Comment 5 Tim-Philipp Müller 2007-11-11 18:26:44 UTC 
> If that information is wrong/outdated, we better update or remove it ...

Agreed, so let's keep the bug open :)
Comment 6 Tim-Philipp Müller 2012-09-28 18:03:13 UTC 
commit 58d21a49d1de8f66a17e2136d9c8d458a91c6ca2
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Fri Sep 28 10:04:51 2012 +0200

    pwg: fix more negotiation for 1.0

commit b68c7fc9549ed3e40d2526289327ddea06e34fae
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Thu Sep 27 17:21:53 2012 +0200

    pwg: fix some negotiation to 1.0