After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 490202 - Missing a ref() when returning a CORBA object via an accessible
Missing a ref() when returning a CORBA object via an accessible
Status: RESOLVED NOTABUG
Product: pyatspi2
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Eitan Isaacson
Li Yuan
Depends on:
Blocks:
 
 
Reported: 2007-10-25 16:45 UTC by Eitan Isaacson
Modified: 2019-03-27 20:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Ref() a return value (549 bytes, patch)
2007-10-25 16:47 UTC, Eitan Isaacson 		committed Details | Review

Description Eitan Isaacson 2007-10-25 16:45:58 UTC 
The patch below does a ref() when we get back an accessible or other corba object, for example acc.parent or acc.getChildAtIndex().
Comment 1 Eitan Isaacson 2007-10-25 16:47:13 UTC 
Created attachment 97860 [details] [review]
Ref() a return value
Comment 2 Eitan Isaacson 2007-11-01 20:40:31 UTC 
This patch was bad. When we get a CORBA object from a method call it is always reffed for us. I am going to revert it, both in stable and in trunk.

I was able to suppress an Orca bug with this patch, but it was not the right fix, it just reffed the returned object an extra time, another round trip, and also i am working on a mixin that unrefs on __del__, and I had to unref() twice, a second extra round trip.

I think that the cause for the Orca bug is bug 492469. I'll test a bit further.
Comment 3 Eitan Isaacson 2007-11-01 21:13:23 UTC 
This patch has been reverted, both in the 2.20 branch and in trunk.