GNOME Bugzilla – Bug 489874
Add Firefox plugin so iTunes podcast links are handled
Last modified: 2007-12-03 13:21:10 UTC
See iTunesMozillaPluginDetected in http://ax.phobos.apple.com.edgesuite.net/detection/itmsCheck.js
Maybe this could go in epiphany instead.
I think it's more appropriate to put the plugin with the programme that will handle those links, not epiphany...
(BTW, their browser detection sucks, they check for "Firefox" directly. -> http://geckoisgecko.org/ )
Does that plugin have a JS API exposed to the web site, or how is it used?
(In reply to comment #1)
> I think it's more appropriate to put the plugin with the programme that will
> handle those links, not epiphany...
> (BTW, their browser detection sucks, they check for "Firefox" directly. ->
> http://geckoisgecko.org/ )
> Does that plugin have a JS API exposed to the web site, or how is it used?
Don't think so. I think it's just a way to see if iTunes is already installed on the computer. Not very important as you can override it anyway, clicking "Yes, I have iTunes"...
In that case it should be easy to create it: just copy epiphany/plugin/desktop-file/plugin.cpp and trim it down to almost nothing :)
The only thing required is probably giving it the expected name.
As Bastien requested (So, if you have a Windows machine with Firefox and iTunes installed, could you please attach the output (pertaining to iTunes) of "about:plugins" from Firefox to the bug?), here is what i get from firefox:
iTunes Application Detector
File name: npitunes.dll
iTunes Detector Plug-in
MIME Type Description Suffixes Enabled
application/itunes-plugin This plug-in detects the presence of iTunes when opening iTunes Store URLs in a web page with Firefox. Yes
Created attachment 97859 [details]
Trimmed down version of ephy's desktop plugin. Tested in ephy's build system, and works great!
Code looks fine to me :)
You can trim it a bit more I think, the mozilla_functions aren't needed anywhere.
This sounds good to me, and looks fine to commit with the appropriate build system bits.
(In reply to comment #7)
> This sounds good to me, and looks fine to commit with the appropriate build
> system bits.
Will do once the code in bug 484768 gets committed...
Proper patch now in bug 484768.
2007-12-03 Bastien Nocera <firstname.lastname@example.org>
* podcast/rhythmbox-itms-plugin.cpp: Add a Mozilla plugin
to allow the iTMS pages to detect that we can handle itms:// URIs