After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 489661 - Remove dead, unshipped code from addressbook/gui/widgets
Remove dead, unshipped code from addressbook/gui/widgets
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Contacts
2.12.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-addressbook-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2007-10-24 03:28 UTC by Matthew Barnes
Modified: 2007-10-25 14:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to remove dead code (6.37 KB, patch)
2007-10-24 03:29 UTC, Matthew Barnes 		committed Details | Review

Description Matthew Barnes 2007-10-24 03:28:27 UTC 
Consider this a piece of bug #478704.  I'm trying to clean Subversion trunk of old, unshipped files so that we don't waste any more time maintaining them.

I spotted a few unshipped files in addressbook/gui/widgets:

   e-addressbook-treeview-adapter.c
   e-addressbook-treeview-adapter.h
   gal-view-factory-treeview.c
   gal-view-factory-treeview.h
   gal-view-treeview.c
   gal-view-treeview.h

According to the ChangeLog, Chris Toshok added these files in Jan, 2003 and they were never enabled and never shipped.  Looks like maybe they were experimental.  See revision 19300 for the exact changes.

I propose removing these files from Subversion, along with the related dead code in e-addressbook-view.c and Makefile.am.
Comment 1 Matthew Barnes 2007-10-24 03:29:09 UTC 
Created attachment 97764 [details] [review]
Patch to remove dead code
Comment 2 Ross Burton 2007-10-25 11:47:37 UTC 
Looks good.
Comment 3 Matthew Barnes 2007-10-25 14:46:57 UTC 
Committed to Subversion trunk (revision 34424).