After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 488119 - critical warnings from gtk_tree_view_get_visible_range
critical warnings from gtk_tree_view_get_visible_range
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkTreeView
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtktreeview-bugs
gtktreeview-bugs
: 465690 469094 501115 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-10-19 02:23 UTC by Matthias Clasen
Modified: 2008-06-08 12:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
a patch (1.39 KB, patch)
2007-10-19 02:25 UTC, Matthias Clasen 		committed Details | Review

Description Matthias Clasen 2007-10-19 02:23:22 UTC 
I am seeing warnings from this function in gnome-system-log:

+ Trace 171302

  • #0 __kernel_vsyscall
  • #1 *__GI_raise
    at ../nptl/sysdeps/unix/sysv/linux/raise.c line 64
  • #2 *__GI_abort
    at abort.c line 88
  • #3 IA__g_logv
    at gmessages.c line 497
  • #4 IA__g_log
    at gmessages.c line 517
  • #5 IA__g_return_if_fail_warning
    at gmessages.c line 532
  • #6 _gtk_tree_view_find_path
    at gtktreeview.c line 9013
  • #7 IA__gtk_tree_view_get_visible_range
    at gtktreeview.c line 13290
  • #8 logview_select_log
    at logview.c line 199
  • #9 loglist_selection_changed
    at loglist.c line 253
  • #10 IA__g_cclosure_marshal_VOID__VOID
    at gmarshal.c line 77
  • #11 IA__g_closure_invoke
    at gclosure.c line 490
  • #12 signal_emit_unlocked_R
    at gsignal.c line 2440
  • #13 IA__g_signal_emit_valist
    at gsignal.c line 2199
  • #14 IA__g_signal_emit
    at gsignal.c line 2243 


See also https://bugzilla.redhat.com/show_bug.cgi?id=321701
Comment 1 Matthias Clasen 2007-10-19 02:25:09 UTC 
Created attachment 97458 [details] [review]
a patch

Kris, does this patch look correct ?
Comment 2 Emmanuele Bassi (:ebassi) 2007-10-19 16:13:32 UTC 
*** Bug 469094 has been marked as a duplicate of this bug. ***
Comment 3 Kristian Rietveld 2007-10-28 13:24:40 UTC 
The patch looks okay to me, although it is a little weird that find_offset() fails here.  Does the GtkTreeView in question not have a full page with items?  In such a case, finding the end path at dy + page_size will of course fail and we probably want to return the last path in the rbtree.

I can we can commit this patch for now, I will look at the case outlined above later on.
Comment 4 palfrey 2007-12-03 16:28:32 UTC 
*** Bug 501115 has been marked as a duplicate of this bug. ***
Comment 5 palfrey 2007-12-03 16:30:42 UTC 
*** Bug 465690 has been marked as a duplicate of this bug. ***
Comment 6 Kristian Rietveld 2008-06-08 12:47:28 UTC 
Committed on trunk.