After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 487932 - The plug-in always fullscreens on the head where it was initially launched
The plug-in always fullscreens on the head where it was initially launched
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Browser plugin (obsolete)
2.20.x
Other All
: Normal normal
: ---
Assigned To: totem-browser-maint
totem-browser-maint
: 487934 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-10-18 15:45 UTC by Niels Vorgaard Christensen
Modified: 2007-10-19 11:31 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20


Attachments
Proposed patch (798 bytes, patch)
2007-10-18 15:55 UTC, Niels Vorgaard Christensen
none Details | Review
totem-browser-fullscreen-xinerama.patch (886 bytes, patch)
2007-10-18 16:42 UTC, Bastien Nocera
committed Details | Review

Description Niels Vorgaard Christensen 2007-10-18 15:45:39 UTC
Please describe the problem:
In xinerama setups, there is no way to make the plug-in fullscreen on any other head, than the one where it was initially launched.

It is of course possible to launch totem from the plug-in, move it to the desired head, and then fullscreen totem. But I think a better solution would be, for the plug-in to always fullscreen on the head, where the video is currently playing.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Bastien Nocera 2007-10-18 15:49:05 UTC
*** Bug 487934 has been marked as a duplicate of this bug. ***
Comment 2 Niels Vorgaard Christensen 2007-10-18 15:55:56 UTC
Created attachment 97426 [details] [review]
Proposed patch
Comment 3 Bastien Nocera 2007-10-18 16:42:27 UTC
Created attachment 97428 [details] [review]
totem-browser-fullscreen-xinerama.patch

Could you please test that patch?

It uses the actually monitor location (ie. in which monitor is the biggest part of the video widget) rather than the origin of the video widget.
Comment 4 Niels Vorgaard Christensen 2007-10-19 07:52:28 UTC
That works great. I cannot see any difference in the effects of the two patches: The plug-in apparently fullscreens on the monitor showing the biggest part of the video widget. So maybe it is just matter of taste, whether the window manager or gdk_screen_get_monitor_at_window() should decide the monitor to fullscreen on. Either would be great.
Comment 5 Bastien Nocera 2007-10-19 11:31:16 UTC
Fixed in gnome-2-20 and trunk. Thanks!

2007-10-19  Bastien Nocera  <hadess@hadess.net>

        * browser-plugin/totem-plugin-viewer.c:
        (totem_embedded_toggle_fullscreen):
        Put the fullscreen window on the screen where the video
        widget is, when using Xinerama (Closes: #487932)