After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 487916 - patches for mergeant build problems
patches for mergeant build problems
Status: RESOLVED FIXED
Product: mergeant
Classification: Deprecated
Component: General
0.66
Other Linux
: Normal major
: ---
Assigned To: malerba
gnome-db Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-10-18 14:22 UTC by Stanislav Brabec
Modified: 2007-10-25 09:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
mergeant-implicit-declarations.patch (1.74 KB, patch)
2007-10-18 14:23 UTC, Stanislav Brabec
none Details | Review
mergeant-data.patch (6.35 KB, patch)
2007-10-18 14:23 UTC, Stanislav Brabec
none Details | Review

Description Stanislav Brabec 2007-10-18 14:22:48 UTC
Attached patches fixes following important build problems of mergeant:

mergeant-implicit-declarations.patch: Fixes implicit declarations causing potential crash for platforms with different sizes of pointer and integer (x86_64).

mergeant-data.patch: Compoud patch fixing support data files. It fixes following issues:

- Migrates obsolete (since GNOME 2.8) GNOME Mime Info to Shared MIME Info.

- Implements --disable-update-mimedb to for packaging of Shared MIME info.

- Fixed desktop file:
  - Added GenericName
  - Don't use not allowed relative path
  - Use approved Categories

- Fixes make distcheck

- Moves mergeant.png to one of two approved locations of desktop file icon.

- Moves MIME icon to proper location (TODO: Redesign icon to conform MIME icon conventions).

After applying of this patch, you have to do:

mv data/gnome-application-x-mergeant.png data/application-x-mergeant.png 
rm data/mergeant.applications data/mergeant.keys.in data/mergeant.keys data/mergeant.mime 

WARNING: I am not able to find any reference to many image files installed to datadir/pixmaps/mergeant, so I did not verify, that move of mergeant.png from datadir/pixmaps/mergeant/mergeant.png to datadir/pixmaps/mergeant.png is correct. If not, you have to make a copy or symlink.
Comment 1 Stanislav Brabec 2007-10-18 14:23:29 UTC
Created attachment 97420 [details] [review]
mergeant-implicit-declarations.patch
Comment 2 Stanislav Brabec 2007-10-18 14:23:45 UTC
Created attachment 97421 [details] [review]
mergeant-data.patch
Comment 3 malerba 2007-10-25 09:15:14 UTC
Patches applied, thanks!