After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 486971 - [verified]Where Am I doesn't present toggle button state
[verified]Where Am I doesn't present toggle button state
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: 2.22.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 468098
 
 
Reported: 2007-10-15 21:59 UTC by Willie Walker
Modified: 2008-07-22 19:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (3.30 KB, patch)
2007-12-01 02:13 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review

Description Willie Walker 2007-10-15 21:59:35 UTC 
Steps to reproduce:

1) Run the Expander demo.  The "Details" thing is a toggle button

2) Do a basic "Where Am I" via KP_Enter. 

3) Orca should present the toggle button state (e.g., pressed or not pressed).
Comment 1 Willie Walker 2007-10-26 22:03:06 UTC 
See also test/keystrokes/gtk-demo/role_toggle_button.py
Comment 2 Joanmarie Diggs (IRC: joanie) 2007-12-01 02:13:09 UTC 
Created attachment 99941 [details] [review]
proposed patch

Mike please test.  

Will please review.  Also, while the updated tests (remove "bug" and add the state to the assertions) work fine for me, the first test fails independent of this bug.  When you give it a try, please let me know if the first test's assertions fail on your box as well.  If it does, I'll update this patch.

Thanks guys!

(p.s. already pylinted)
Comment 3 Willie Walker 2007-12-02 20:00:57 UTC 
Looks good to me.  As with the other patches, I've been running the regression tests, too, and they seem to be doing well.  Thanks!
Comment 4 Joanmarie Diggs (IRC: joanie) 2007-12-02 20:49:09 UTC 
Thanks.  Committed. Moving to pending.  Updated the target milestone.
Comment 5 Mike Pedersen 2007-12-04 18:21:29 UTC 
works great
Comment 6 Joanmarie Diggs (IRC: joanie) 2007-12-04 19:20:08 UTC 
Thanks closing as FIXED.