GNOME Bugzilla – Bug 486926
Changes to splitpane value not being spoken
Last modified: 2008-07-22 19:32:31 UTC
Steps to reproduce: 1) Run the Paned Widgets demo of gtk-demo 2) Press F8 to move to the slider (you don't get a visual indicator for this, but that's not Orca's bug) 3) Press the Left and Right arrow keys Orca presents the new split pane value in braille, but not in speech. KP_Enter for Where Am I on the split pane also doesn't speak its value (I put this here because I think solving the above should hopefully also solve the Where Am I problem -- I hope).
See also test/keystrokes/gtk-demo/role_split_pane.py
Created attachment 98121 [details] [review] Patch to hopefully fix the problem. This turned out to be more involved then initially expected. Firstly, there was almost identical code in _getTextForValue() in braillegenerator.py and in _getSpeechForSlider() in speechgenerator.py, to handle the object value. Rather than put yet another similar piece of code in _getSpeechForSplitPane(), I created a getTextForValue() routine in default.py, and adjusted all the code to use that. Secondly, there was a problem in onValueChanged() in default.py. The "oldValue" should only be set if we get a "object:property-change:accessible-value" event for an object with a FOCUSED state. We seem to get two such events each time an arrow key is pressed; one for the new location and one for the initial value. The second one is for the FOCUSED object. The speech presentation for a split pane is now the same as for a slider object. Mike, before I update the test for this, can you confirm that that is the desired behavior? Thanks.
I think this looks/works great, and I like the code clean up. Thanks! While it might be nice to have this for gnome2-20, I don't think it's enough of a high visibility problem to warrant the extra effort. That is, unless you think it would be trivial.
> While it might be nice to have this for gnome2-20, I don't think it's enough > of a high visibility problem to warrant the extra effort. That is, unless > you think it would be trivial. I suggest against it too. The code would definitely be different for GNOME 2.20.X (we used to annotate the event.source with "oldValue"), and it's an extensive change that doesn't really gain a lot (how many Orca users know or care that F8 allows you to get to the split pane to adjust it?)
I think this is a good fix. I don't see any need to add it to 2.20 though.
Patch committed to just SVN trunk. As three of us have now tested this, closing as FIXED. Thanks.