After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 486548 - gnome-main-menu doesn't use xdg directories
gnome-main-menu doesn't use xdg directories
Status: RESOLVED FIXED
Product: gnome-main-menu
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME main menu maintainers
GNOME main menu maintainers
: 578371 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-10-14 12:07 UTC by javiermon
Modified: 2010-02-18 00:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Simple patch to fix this. (2.17 KB, patch)
2008-11-29 22:40 UTC, Gert Kulyk 		committed Details | Review
A different patch (2.28 KB, patch)
2009-04-08 14:38 UTC, Julian Andres Klode 		committed Details | Review

Description javiermon 2007-10-14 12:07:39 UTC 
Please describe the problem:
Hi

Ubuntu and other distro's now use xdg directories (http://www.freedesktop.org/wiki/Software/xdg-user-dirs) but slab default's to the old locations (~/Desktop, etc) and so the desktop icon in the places tab doesn't work.

This happens in slab 0.9.8

thanks

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Gert Kulyk 2008-11-29 22:40:59 UTC 
Created attachment 123673 [details] [review]
Simple patch to fix this.

Here is a patch that fixes the issue for me.
Comment 2 Khashayar Naderehvandi 2009-01-13 08:29:31 UTC 
Any plans on having this patch applied?
Comment 3 pazkooda 2009-03-12 19:53:24 UTC 
Just want to confirm this bug.

Please fix this upstream as this is trivial operation having a provided patch.
Comment 4 Julian Andres Klode 2009-04-08 14:24:12 UTC 
*** Bug 578371 has been marked as a duplicate of this bug. ***
Comment 5 Julian Andres Klode 2009-04-08 14:38:26 UTC 
Created attachment 132343 [details] [review]
A different patch

This patch uses g_get_user_special_dir() directly and does not call g_build_filename() on its return value.
Comment 6 Julian Andres Klode 2009-04-10 15:30:16 UTC 
I will apply a patch in the version shipped in Debian GNU/Linux, but this should be fixed upstream too. Therefore, please fix this.

The patch I provided seems to have some problems, you might want to try the one provided in Comment #1.

Thank you.
Comment 7 Julian Andres Klode 2009-09-02 18:09:00 UTC 
The bug is now open for 2 years already, could someone please take care of it?
Comment 8 Julian Andres Klode 2010-02-07 16:24:36 UTC 
I have pushed commits to my branches to fix this bug:
  git://git.debian.org/users/jak/gnome-main-menu.git
  git://git.debian.org/users/jak/libslab.git

and hope that someone pulls those branches into the gnome.org ones (I already sent an email to them).
Comment 9 Vincent Untz 2010-02-18 00:02:05 UTC 
Pushed the patch, thanks.