After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 486543 - Cannot play any radio stations when started from root directory
Cannot play any radio stations when started from root directory
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: 2.x
Assigned To: Banshee Maintainers
Banshee Maintainers
: 608300 612658 633463 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-10-14 11:39 UTC by Sebastian Pölsterl
Modified: 2011-01-22 15:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Don't use Environment.CurrentDirectory for the base uri (1.39 KB, patch)
2009-01-04 13:30 UTC, Bertrand Lorentz
rejected Details | Review

Description Sebastian Pölsterl 2007-10-14 11:39:22 UTC
I'm using Music-Applet on latest Ubuntu gutsy.

The problem is that Banshee differs if started from the applet or from the command line or menu [1][2]. Starting from the applet, music that's on my hard drive works perfectly, but I can not play any radio station. I tried both launching via D-Bus and Command, the result is always the same.

[1]: http://www.k-d-w.org/clipboard/Banshee-applet.png
[2]: http://www.k-d-w.org/clipboard/Banshee-cmd.png

I already contacted the developer of Music-Applet and he answered:

It looks like a Banshee bug, as it happens even when Music Applet isn't
even running.

It's also a weird bug.  Launching just "banshee" from the command line works, but launching "banshee" from within Music Applet, or using D-Bus either through Music Applet or via dbus-send on the command line, doesn't.  Also, when Banshee is invoked in a way that exhibits the bug, only the six radio stations filed under "RadioPass" show up; when the bug isn't there, 22 stations show up across various categories. Very strange.

I don't know what's going on with this, but it must be some kind of bug in Banshee.  Hopefully those developers will be able to figure it out.
Comment 1 Andrew Conkling 2008-02-08 01:20:01 UTC
What comes up if you run Banshee via dbus-launch, e.g. `dbus-launch banshee`?
Comment 2 Andrew Conkling 2008-03-11 16:14:59 UTC
Closing this bug report as no further information has been provided. Please feel free to reopen this bug if you can provide the information asked for.
Thanks!
Comment 3 Sebastian Pölsterl 2008-03-27 12:00:48 UTC
When I run "dbus-launch banshee" it works fine.
Comment 4 Bertrand Lorentz 2009-01-04 11:44:08 UTC
This issue is still present with the latest banshee and music-applet versions : if banshee is started by music-applet, I cannot play any radio stations.

The problem is in banshee :
When banshee is started by music-applet, Environment.CurrentDirectory is "/". In PlaylistParser.cs, this line then causes an UriFormatException :
private Uri base_uri = new Uri (Environment.CurrentDirectory);

You can also reproduce the problem by doing a "cd /;banshee-1".
Comment 5 Bertrand Lorentz 2009-01-04 13:30:31 UTC
Created attachment 125734 [details] [review]
Don't use Environment.CurrentDirectory for the base uri

This patch should fix this issue.
There's a third place where Environment.CurrentDirectory is used in an URI, but it's handled by the patch in bug #559654.
Comment 6 Gabriel Burt 2009-01-13 17:04:39 UTC
Bertrand, what path/URI is being pased from the music-applet to banshee?  Is it really a relative path at all?  If the setting for the baseDirectory is causing the problem, we should allow setting it to null probably - setting it to the Assembly's location makes zero sense to me.
Comment 7 Bertrand Lorentz 2009-01-13 20:10:11 UTC
Music-applet is not passing any URI to banshee, it's just starting it. The problem is caused by the fact that $PWD is /.

You can see the problem without music-applet. Just run "cd /;banshee-1".

I don't really understand this BaseUri thing either.
Comment 8 Gabriel Burt 2009-01-13 20:28:23 UTC
The point of the BaseUri is so that if you run

$ cd Music/
$ banshee-1 foo.m3u

and the files listed in foo.m3u have relative uris, then Banshee will use the PWD to create the correct absolute uri.
Comment 9 rjb 2009-11-01 12:34:11 UTC
I'm using Banshee 1.6 Beta 2 (1.5.1) on Ubuntu 9.10 (Karmic Koala).
When started through the Applications menu, Banshee plays my radio station fine.
When started through Music Applet 2.5.0 it won't play my radio station.
The radio station URL is http://105-stream-02.datacomm.ch:8000/rocknation
Comment 10 Bertrand Lorentz 2010-01-28 19:40:46 UTC
*** Bug 608300 has been marked as a duplicate of this bug. ***
Comment 11 Bertrand Lorentz 2010-03-30 20:03:33 UTC
*** Bug 612658 has been marked as a duplicate of this bug. ***
Comment 12 Michael Martin-Smucker 2010-10-29 14:31:09 UTC
*** Bug 633463 has been marked as a duplicate of this bug. ***
Comment 13 Michael Martin-Smucker 2010-10-29 14:35:37 UTC
From Bug 633463, it sounds like this issue also causes problems if Banshee is launched from Ubuntu's sound menu.  Since Banshee is going to be the default music player in Ubuntu 11.04 (woo!) it might not hurt to give this some love between now and the next stable release.
Comment 14 Bertrand Lorentz 2011-01-22 15:05:27 UTC
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.

I just committed a different fix, to both git master and the stable-1.8 branch :
http://git.gnome.org/browse/banshee/commit/?id=348a9032