After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 485903 - [verified] Orca doesn't read message list in gmail
[verified] Orca doesn't read message list in gmail
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: speech
2.20.x
Other All
: Normal normal
: 2.20.2
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2007-10-12 00:49 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2007-11-05 20:24 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20


Attachments
sanity check in the label guessing functionality (1.30 KB, patch)
2007-10-12 01:10 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review
patch updated for trunk (1.31 KB, patch)
2007-11-03 20:40 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2007-10-12 00:49:51 UTC
As reported by Javier on the Orca list:

> I am trying to access my Gmail account with Orca/firefox latest svn
> version.
> 
> When I login at gmail (http://www.gmail.com) and I try to read the
> message list (the first table in the basic html view mode) Orca doesn't
> speak the rows in the table, however I can't see it in my braille
> display.
> 
> Is this a known bug?

It is now.  :-)  Patch to follow.
Comment 1 Joanmarie Diggs (IRC: joanie) 2007-10-12 01:10:05 UTC
Created attachment 97101 [details] [review]
sanity check in the label guessing functionality

The Gmail checkboxes are causing the label guessing functionality to kick in.  The Gmail table is passing the "it's probably a grid" test.  Things that are probably grids probably have a label at the top indicating what the column is, right?  (hint:  wrong) ;-)

This patch checks to see that we have a nextCell (and thus extents) before we try to do stuff with those extents, get cell coordinates, etc.
Comment 2 Willie Walker 2007-10-17 14:48:00 UTC
Does this patch work on our gnome-2-20 branch?  If not, can you please make one for it so Mike can test it with gnome-2-20?  If it works well, we can shoot to get this in the GNOME 2.20.2 release.
Comment 3 Joanmarie Diggs (IRC: joanie) 2007-10-17 14:56:19 UTC
This patch works with the gnome-2-20 branch as is.
Comment 4 Willie Walker 2007-11-01 19:37:09 UTC
I don't do gmail, so I cannot test this.  Mike, please test.  :-)
Comment 5 Mike Pedersen 2007-11-02 17:58:31 UTC
Saddly this patch nolonger applies to trunk. 
Comment 6 Joanmarie Diggs (IRC: joanie) 2007-11-03 20:40:29 UTC
Created attachment 98482 [details] [review]
patch updated for trunk

The thing I don't get is that this patch is the same as the last version not counting the line numbers.  Anyhoo, please give this one a try.  Thanks.
Comment 7 Mike Pedersen 2007-11-03 21:13:25 UTC
hmmmmmm this one applied just fine.  Still testing
Comment 8 Mike Pedersen 2007-11-05 18:48:04 UTC
I think this one looks good now. 
Comment 9 Joanmarie Diggs (IRC: joanie) 2007-11-05 20:24:00 UTC
Thanks guys.  Patch committed to both the 2-20 branch and trunk.  Closing as FIXED.