After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 485535 - the artwork is only copied for read tracks
the artwork is only copied for read tracks
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: iPod
0.11.x
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-10-10 22:05 UTC by Sebastien Bacher
Modified: 2009-04-14 08:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
copy COvert Art to iPod (2.01 KB, patch)
2008-01-03 22:48 UTC, Nicolas Aguirre
rejected Details | Review

Description Sebastien Bacher 2007-10-10 22:05:31 UTC
You need to read the track before copying it if you want to get the artwork on your ipod, that should not be required
Comment 1 Sebastien Bacher 2007-10-10 22:14:00 UTC
The copy of artwork when doing a dnd between the list of albums and the ipod seems to also have issues
Comment 2 Nicolas Aguirre 2008-01-03 22:48:50 UTC
Created attachment 102074 [details] [review]
copy COvert Art to iPod
Comment 3 Nicolas Aguirre 2008-01-03 22:49:46 UTC
Comment on attachment 102074 [details] [review]
copy COvert Art to iPod

I have some trouble to copied artwork on iPod. Artwork is copied only if song is currently playing. It seems that rhythmdb_entry_request_extra_metadata function in  request_artwork of rb-ipod-source.c does not handle correctly pixbuf metadata. 
I have write a tiny and quick and dirty patch, in order to copy artwork on device. It took ArtDisplay cover in $HOME/.gnome2/rhythmbox/covers/.

It may have memory leaks (pixbuf is not freed).
 
It works here on ipod 5G and ipod nano 3G with SVN libgpod and SVN rhythmbox of 01/03/2008.

Nico
Comment 4 Jonathan Matthew 2008-01-03 23:17:54 UTC
Please remove the debug printfs and weird whitespace changes before submitting patches.  Same goes for memory leaks too.

The ipod plugin can't assume it knows how the artdisplay plugin will store the images it downloads.  If the extra-metadata request that we currently do doesn't work, we need to fix it rather than adding an ugly hack of a workaround.

Might I suggest that you use your real name in bugzilla too?
Comment 5 Nicolas Aguirre 2008-01-10 18:30:50 UTC
first all my aplogies for this patch, and thanks for you review and advices. I think that my real name should be shown on bugzilla now. My last patch was effectively horrible and I'll look at dev coding rules in the future. 

I try to work again on this problem. As you said, extra-metadata request doesn't work. The event rb:coverArt is used, to get pixbuf of cover. I have try do to exactly the same think but with rb:coverArt-uri and creating pixbuf with this uri. I have exactly the same behaviour, only song actulay played have a cover on iPod. 

I'm agree that my previous solution (creation of uri with song artist and album strings) is not the right way, but I have no other solution in mind, maybe have you already  thought in a better solution to solve this issue ?
Comment 6 Keffin Barnaby 2008-03-16 19:21:19 UTC
Has there been any progress on this bug? It makes migrating to Rhythmbox rather suboptimal...
Comment 7 Niels Vorgaard Christensen 2008-04-25 11:53:31 UTC
The bug is really in the artdisplay plugin. See bug 529873.
Comment 8 Jonathan Matthew 2009-04-14 08:54:24 UTC
This should work now that bug 529873 has been fixed.  It certainly works for MTP devices.