GNOME Bugzilla – Bug 48501
drag same emblem to a file twice - the emblem gets removed
Last modified: 2010-08-02 12:20:31 UTC
running Solaris 8 on an ultra 110 it was seen that if the user drags an emblem to a file, then drags the same emblem again to the same file, the emblem gets removed. What i would have expected is that the emblem gets left on the file, till it's turned off in the properties dialog, or the erase emblem is dragged to the file... ------- Bug moved to this database by unknown@bugzilla.gnome.org 2001-09-09 21:18 -------
Changing to "old" target milestone for all bugs laying around with no milestone set.
I think this is working as designed. But someone could work to refine the user interface of this. The change sounds OK to me.
Maybe seth has a suggestion?
I think its better to have the emblem removed than to do nothing. If somebody wanted to do the work, one idea might be to change the cursor to a minus sign when you drag an emblem somewhere where it will actually remove an existing emblem.
There is currently no direct way to modify the GTK+ drag cursor. It just uses some internally #defined cursors (gtkdndcursors.h). There is no minus sign available IMHO. All we could do is blending the emblem icon with a minus sign.
Created attachment 124579 [details] [review] Patch to correct the bug 48501
In order to correct the bug, provided that you think this is a bug, you should remove some lines in the file libnautilus-private/nautilus-file-dnd.c, especially in the function nautilus_drag_file_receive_dropped_keyword. I put a patch as an attachment.
What I think should be the proper behavior is to display a '-' when the emblem is dragged again on the icon... removing the ability to remove the emblem is not really helping (in my humble opinion).
I'd second that last comment, perhaps the cursor can be changed to the "eraser" emblem.
Nah, it would be confusing because the usual semantic for the eraser is to remove all emblems at once. Having the ability to remove only one emblem by dragging it a second time over the icon AND with a clear semantic (the minus sign) would be the proper way to do it (or am I wrong ?).
'Backgrounds and Emblems' have now been removed from nautilus master, see [1]. Closing this as OBSOLETE. [1] http://mail.gnome.org/archives/nautilus-list/2010-July/msg00023.html