GNOME Bugzilla – Bug 48427
Hidden files on FTP sites never shown in Nautilus
Last modified: 2005-06-03 07:46:24 UTC
The 'Show Hidden Files' preference doesn't have any effect when viewing FTP directories in Nautilus. ------- Additional Comments From yakk@yakk.net 2001-07-20 16:27:58 ---- Jonas, When you log into the site and to a "ls", do the hidden files show up? Can you give me the url of an FTP site to reproduce this? ------- Additional Comments From jonas.devuyst@advalvas.be 2001-07-20 16:45:40 ---- Hi, When I use 'ftp' and do an 'ls' then the files don't show up. If I do an 'ls -a', however, they do show up. I also just tried gftp and the hidden file showed up in there (hidden directories OTOH don't show up in it.. I'll report this bug tomorrow). I encountered the same behaviour with the few FTPs I tried this with, if your experience is different then you could perhaps try http://www.netfirms.com/. ------- Additional Comments From jonas.devuyst@advalvas.be 2001-07-28 13:46:52 ---- Seems I was incorrect about gftps behaviour. I was looking at cached data. But I took a look at ftp-method.c and the problem seems to be that the command "LIST -ld" or "LIST -ldL" is sent to the server, which queries only for normally visible files. I think that replacing both instances of "LIST -ld" with "LIST -lda" and the two instances of "LIST -ldL" with "LIST -ldLa" will solve the problem. I haven't tested this on GnomeVFS because I didn't really understand what was happening in the source file, that's also the reason that I don't have a patch. I have, however, tested this command with a Java API that had the same problem and everything seemed to work as espected. Hope this helps. ------- Additional Comments From yakk@yakk.net 2001-07-30 12:07:36 ---- Yep - I think you've isolated the problem. I'll try to get this fix in sometime soon. Thanks for picking this up. ------- Bug moved to this database by unknown@bugzilla.gnome.org 2001-09-09 21:18 -------
*** Bug 167511 has been marked as a duplicate of this bug. ***
Created attachment 45911 [details] [review] Proposed patch (against HEAD). This patch does * add a handler for the 504 ftp status code (bad command parameter) * add a check (first time an open_directory is done) whether the server shows hidden files * fix a potential leak by adding a g_string_free_call Could sb. please verify that this works correctly on servers that do NOT support hidden files? I couldn't find any. But at least hidden file listing works as expected for servers that do support it :).
Created attachment 46249 [details] [review] Proposed patch #2 (against HEAD). Heavily improved patch. It does not only look way cleaner, in contrast to attachment 45911 [details] [review] it also tries out multiple LIST parameter combinations and therefore also fixes bug 170577.
Created attachment 46250 [details] [review] Proposed patch #3 (against HEAD). Eeek. attachment 46249 [details] [review] would have broken MacOS X servers.
Marking bug 48427 as dependant upon this one since patch #3 should also fix this issue.
I would replace /* shouldn't happen, since we either should have failed with the last candidate or should * have found a working command */ conn->list_cmd = NULL; return GNOME_VFS_ERROR_INTERNAL; in get_list_command with a g_assert_not_reached ();
Created attachment 46297 [details] [review] Proposed patch #4 (against HEAD) Changes: * Implement Alex's suggestion. I wasn't sure whether this would be suitable for a library, but this code should really never ever be reached * Fix if statement in "default:" section * Coding-style
Created attachment 47072 [details] [review] Proposed patch #5 (against HEAD). At GUADEC, Christian Kellner suggested many tiny changes (mostly coding style). They rectify a rewrite. This one looks and feels way cleaner.
Created attachment 47073 [details] [review] Proposed patch #6. Added another assert.
Created attachment 47132 [details] [review] Proposed patch #7 (hopefully last one).
Committed slightly different version (with a pointer fix).