After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 483826 - inhibit applet does not work with no-background panels
inhibit applet does not work with no-background panels
Status: RESOLVED FIXED
Product: gnome-power-manager
Classification: Deprecated
Component: applets
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Power Manager Maintainer(s)
GNOME Power Manager Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2007-10-05 17:58 UTC by Matthias Clasen
Modified: 2008-08-16 22:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
no-background.patch (3.55 KB, patch)
2007-10-05 17:59 UTC, Matthias Clasen 		none Details | Review
automatic icon drawn over inhibit icon (1.66 KB, image/png)
2007-10-05 20:28 UTC, Matthias Clasen 		  Details

Description Matthias Clasen 2007-10-05 17:58:59 UTC 
Since the new icon just gets drawn over the old one. 

Here is a patch to make the applet uee a GtkImage for the acutal icon drawing.
That works.
Comment 1 Matthias Clasen 2007-10-05 17:59:42 UTC 
Created attachment 96721 [details] [review]
no-background.patch

Not a very nice patch, sorry. I just ifdefed out the parts that I don't need anymore.
Comment 2 Richard Hughes 2007-10-05 19:41:02 UTC 
I must admit I can't reproduce the bug. Have you got a screenshot? I'll convert the other applet (brightness) if you think it might have merit. Thanks.
Comment 3 Matthias Clasen 2007-10-05 20:28:02 UTC 
Created attachment 96724 [details]
automatic icon drawn over inhibit icon

It only happens if you use "None" for the panel background.
Comment 4 Richard Hughes 2007-10-05 22:14:21 UTC 
Yup, fixed now, thanks. Does the brightness applet need the fix also?
Comment 5 Matthias Clasen 2007-10-05 23:01:06 UTC 
Forgot to mention it: no, the brightness applet can do without, since it does not display different icons. I guess you could perhaps make it show artifacts by theme switching, though.
Comment 6 Matthias Clasen 2007-10-07 01:42:54 UTC 
Turns out the patch I attached causes the applet to eat 100% cpu, which was quickly spotted by our avid rawhide users...

You want to take out the 

        gpm_applet_get_icon (applet);

call from the draw_cb(), otherwise you end up loading the svg for every expose event, which is not fun.
Comment 7 Matthias Clasen 2008-08-16 22:37:11 UTC 
I think this is all taken care of now.