GNOME Bugzilla – Bug 483018
We should remove (or redefine) the orca speech change hotkeys
Last modified: 2007-10-12 15:40:50 UTC
We should remove the hotkeys for changing the speech rate and pitch. This is necessary to make it possible to use these keys for application specific functionality. If the community requests it we can put the speech change feature on other less common key strokes.
Created attachment 96702 [details] [review] Version 1 This patch just removes the hot-key definitions for these for functions. I believe this is all we need but ...
Created attachment 96703 [details] [review] Version 2. This version removes the four hot-key definitions plus all the underlying methods to do this functionality. I suspect we want to keep them so that they can be maybe be remapped to other keys. Just generating both versions for completeness. Will, Mike, tell me which one to obsolete. Thanks.
Rich, I think we want to leave the underlying functionality in, but remove or redefine the keys used to adjust the given speech parameters from the keyboard. Mike needs to work with the community on whether we should remove the keystrokes altogether or just redefine them. Until a conclusion is reached there, I think we need to hold off on this bug.
Then it's version #1 you want. I'll obsolete the other one. Note that Mike opened a second bug to redefine those keys. This bug is now ready for others to test. Thanks.
I'm retitling the summary of this bug to reflect that the decision to remove or redefine the keys to modify speech parameters has not been made. That is, bug 483023 deals with wanting to use the current keys for something else, and we need to decide whether or not we want to define new keys for adjusting speech parameters.
Yep this is what we need for this one.
Sorry I didn't read all the comments. Please obsolete the second one.
For this one, we just want to remove the keys, but leave the handlers in there. So, just this portion of the patch: keyBindings.add( keybindings.KeyBinding( - "Left", - 1 << settings.MODIFIER_ORCA, - 1 << settings.MODIFIER_ORCA, - self.inputEventHandlers["decreaseSpeechRateHandler"])) - - keyBindings.add( - keybindings.KeyBinding( - "Right", - 1 << settings.MODIFIER_ORCA, - 1 << settings.MODIFIER_ORCA, - self.inputEventHandlers["increaseSpeechRateHandler"])) - - keyBindings.add( - keybindings.KeyBinding( - "Down", - 1 << settings.MODIFIER_ORCA, - 1 << settings.MODIFIER_ORCA, - self.inputEventHandlers["decreaseSpeechPitchHandler"])) - - keyBindings.add( - keybindings.KeyBinding( - "Up", - 1 << settings.MODIFIER_ORCA, - 1 << settings.MODIFIER_ORCA, - self.inputEventHandlers["increaseSpeechPitchHandler"])) - - keyBindings.add( - keybindings.KeyBinding( "q", 1 << settings.MODIFIER_ORCA, 1 << settings.MODIFIER_ORCA, We want to leave the input event handler definitions in there so that users can bind to them if they want to. The work for bug 481488 will be the thing that helps them to do this.
Created attachment 97024 [details] [review] Revised version of Version 1 patch per comment #8
Latest patch checked into SVN trunk. Setting to "[pending]".
Looks good to me.
Thanks. Closing as FIXED.