After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 482147 - [queue] Issue with current time level if source task is not started
[queue] Issue with current time level if source task is not started
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.10.31
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-10-01 12:28 UTC by Edward Hervey
Modified: 2010-10-11 14:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Apply the sink segment on the source immediately when it is received if the queue is empty (3.46 KB, patch)
2010-02-18 09:50 UTC, Ognyan Tonchev (redstar_) 		none Details | Review
patch rebased to latest gstreamer (3.30 KB, patch)
2010-03-10 12:59 UTC, Ognyan Tonchev (redstar_) 		none Details | Review
Fixed a small bug in the previous patch (3.30 KB, patch)
2010-04-15 15:27 UTC, Ognyan Tonchev (redstar_) 		none Details | Review
added unit test (6.35 KB, patch)
2010-08-25 10:20 UTC, Ognyan Tonchev (redstar_) 		none Details | Review
patch updated - apply only the first new segment on src (4.88 KB, patch)
2010-10-11 09:34 UTC, Ognyan Tonchev (redstar_) 		none Details | Review

Description Edward Hervey 2007-10-01 12:28:08 UTC 
If the source task of queue is not started, the current time level will be wrong since the real current segment hasn't been set on queue->src_segment.

Commented the broken line in gstqueue.c until it is fixed with a comment linking to this bug.
Comment 1 Wim Taymans 2009-08-28 15:54:33 UTC 
one possible solution would be to apply the sink segment on the source immediatly when it is received and there is nothing in the queue. We have to make sure that we don't reaply it when we push the segment then.
Comment 2 Ognyan Tonchev (redstar_) 2010-02-18 09:50:42 UTC 
Created attachment 154114 [details] [review]
Apply the sink segment on the source immediately when it is received if the queue is empty
Comment 3 Ognyan Tonchev (redstar_) 2010-03-10 12:59:17 UTC 
Created attachment 155739 [details] [review]
patch rebased to latest gstreamer
Comment 4 Ognyan Tonchev (redstar_) 2010-04-15 15:27:57 UTC 
Created attachment 158823 [details] [review]
Fixed a small bug in the previous patch
Comment 5 Ognyan Tonchev (redstar_) 2010-08-25 10:20:46 UTC 
Created attachment 168715 [details] [review]
added unit test
Comment 6 Ognyan Tonchev (redstar_) 2010-10-11 09:34:13 UTC 
Created attachment 172091 [details] [review]
patch updated - apply only the first new segment on src
Comment 7 Wim Taymans 2010-10-11 14:14:09 UTC 
commit 36b533d5b2689cffa916f02f32bed3446112b612
Author: Ognyan Tonchev <ognyan@axis.com>
Date:   Mon Oct 11 10:27:52 2010 +0200

    queue: apply sink segment on the source if queue is empty
    
    Apply the sink segment on the source immediatly when it is received
    and there is nothing in the queue.
    
    Solves #482147