After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 480861 - Handling of import errors
Handling of import errors
Status: RESOLVED WONTFIX
Product: f-spot
Classification: Other
Component: Import
SVN
Other Linux
: Normal enhancement
: ---
Assigned To: F-spot maintainers
F-spot maintainers
gnome[unmaintained]
: 494203 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-09-27 08:29 UTC by Glen Birkbeck
Modified: 2018-07-12 00:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
skipall-on-folder-import.patch (1.98 KB, patch)
2008-03-14 10:00 UTC, Maxxer
needs-work Details | Review

Description Glen Birkbeck 2007-09-27 08:29:18 UTC
When importing images from an existing directory structure I receive error messages for a number of files stating cannot import, metadata error. These happen at arbitrary points in the import process, i.e. whenever the file is examined and a problem is found, the import then stops, giving the user the option to Skip or Cancel. 

I guess there is something wrong with the underlying files, so nothing that f-spot could fix there, but the import errors could be gathered up and presented as a choice for the user at the end of the import process. The way it works at the moment - I import about 3600 images, leave it running and when I return I find it has only gone half way through and is awaiting user input, i.e. Skip or Cancel.

Current version is SVN, though the same error occurred with version 0.3 on Ubuntu Feisty
Comment 1 Glen Birkbeck 2007-09-29 07:28:04 UTC
A correction. The error message given is "Object reference not set to an instance of this object". This occurs with zero length files and corrupted RAW files (Nikon NEF)
Comment 2 grmblmbl 2007-12-01 21:26:58 UTC
I get this error too.
When I try to import photos, it sometimes fails and says :

Error importing /path/to/some/photo.jpg
System.NullReferenceException: Object reference not set to an instance of an object
  at FSpot.Xmp.XmpTagsImporter.ProcessStore (FSpot.MetadataStore store, .Photo photo) [0x00000] 
  at FSpot.Xmp.XmpTagsImporter.Import (.Photo photo, System.String path, System.String orig_path) [0x00000] 
  at FileImportBackend.Step (.Photo& photo, Gdk.Pixbuf& thumbnail, System.Int32& count) [0x00000] 
Could not import file
Stopping

And sometimes it works.  I couldn't determine what makes F-spot fail.

I run Mandriva 2008.0 with :
f-spot-0.4.0-2mdv2008.0
mono-1.2.5-4.1mdv2008.0
Comment 3 Maxxer 2007-12-01 21:40:09 UTC
(In reply to comment #2)
> I get this error too.
> When I try to import photos, it sometimes fails and says :

Does it fail always on the same pictures or randomly?
Can you please provide one of those failing pictures? Thanks.


Glen, you might be interested in bug #494203.
Comment 4 grmblmbl 2007-12-01 21:50:06 UTC
Thanks for answering that fast !

It seems to be problematic with the same pictures.
Here's one : http://yhargla.free.fr/p20071201_113752.jpg
Comment 5 Maxxer 2007-12-01 23:04:40 UTC
(In reply to comment #4)

> It seems to be problematic with the same pictures.
> Here's one : http://yhargla.free.fr/p20071201_113752.jpg

Imported fine without problems on last SVN. Can you please try using SVN too?

If you're new to this kind of stuff, you'll find help here:
http://f-spot.org/How_To_Build_from_HEAD

thanks.
Comment 6 Maxxer 2008-03-14 09:59:01 UTC
*** Bug 494203 has been marked as a duplicate of this bug. ***
Comment 7 Maxxer 2008-03-14 10:00:39 UTC
Created attachment 107286 [details] [review]
skipall-on-folder-import.patch

patch from bug 494203

grmblmbl for your problem please refer to bug 501652
Comment 8 Tobias Mueller 2009-01-22 23:36:27 UTC
hm. The question in comment #5 hasn't been answered so far and the patch from comment #7 is still not reviewed or checked in (according to the bugzilla status).

As per comment #5, I tend to close this bug as INCOMPLETE. What do you think Maxxer?
Comment 9 Maxxer 2009-02-01 12:21:34 UTC
(In reply to comment #8)
> As per comment #5, I tend to close this bug as INCOMPLETE. What do you think
> Maxxer?

in f-spot not all bugzilla flags are used, so the patch may be still applied, as is or modified, in future.
thanks
Comment 10 Ruben Vermeersch 2010-06-24 14:49:17 UTC
Comment on attachment 107286 [details] [review]
skipall-on-folder-import.patch

Maintenance update: In the past we've been less than stellar in reviewing patches. As such we have a pile of patches in bugzilla which are outdated and don't apply anymore. Am currently marking all of these as "needs-work". My apologies for this.

Since I've become a maintainer of the project, I've set the personal rule of quickly reviewing all patches, to avoid that this happens again. If you (or anyone) wants to go through the trouble of updating this patch, please talk to us to figure out if it fits in the F-Spot long term roadmap.

Should you, in the future, notice a patch lingering around for too long, please notify us immediately and we'll look into it, to avoid situations like these from happening again.

You can filter these mails by searching for ###F-OLDPATCHCLEANUP###
Comment 11 André Klapper 2018-07-12 00:06:20 UTC
F-Spot has moved to https://github.com/f-spot/f-spot/issues

If this Bugzilla ticket is still valid in a recent version of F-Spot, please feel free to post this topic as a ticket in the F-Spot project on GitHub.

Closing this report as WONTFIX as part of Bugzilla Housekeeping as we are planning to shut down GNOME Bugzilla in favor of GNOME Gitlab.