GNOME Bugzilla – Bug 480264
[verified] ARIA sliders not outputting Braille/ childCount:embed defense
Last modified: 2007-10-30 16:33:15 UTC
ARIA sliders and progressbars are not outputting Braille. This may be due to this Firefox bug https://bugzilla.mozilla.org/show_bug.cgi?id=397485 because contents in updateBraille() as returned by getLineContentsAtOffset() is empty. Another strange observation is that the slider does not always have focus. Sometimes the focus is on other components that make up the slider such as a span or xml-roles:button.
Will, Several defensive maneuvers were put in place for using child() with a childCount=0. Several were already in place in other uses throughout the code. I doubt I got them all and several were a little tricky so please inspect the patch carefully. Mike, Would you please inspect the Braille output for the following sliders: http://www.mozilla.org/access/dhtml/pretty-slider.htm http://archive.dojotoolkit.org/nightly/dojotoolkit/dijit/tests/form/test_Slider.html
Created attachment 96190 [details] [review] first version of ARIA sliders not outputting Braille
Created attachment 96234 [details] [review] second version of ARIA sliders not outputting Braille/ childCount:embed defense Changes that came about from our IRC session.
Created attachment 96235 [details] [review] third version of ARIA sliders not outputting Braille/ childCount:embed defense this patch contains only relevant diffs. Ignore the second version.
Created attachment 96259 [details] [review] fourth version of ARIA sliders not outputting Braille/ childCount:embed defense Additional change included doing a recursive call in findFirstCaretContext() instead of a simple return. This will help overcome situations where there are consecutive bad EOCs.
(In reply to comment #5) > Created an attachment (id=96259) [edit] > fourth version of ARIA sliders not outputting Braille/ childCount:embed defense > > Additional change included doing a recursive call in findFirstCaretContext() > instead of a simple return. This will help overcome situations where there are > consecutive bad EOCs. This is looking very good. Thanks! Everyone, please give this a test against trunk before Scott commits it.
I think this is now good.
Should this be considered for GNOME 2.20.1? Or, is the defense stuff being done here isolated to just ARIA stuff, which is planned for support in GNOME 2.22?
Created attachment 96957 [details] [review] updated patch for ARIA sliders not outputting Braille Joanie, Here is an updated patch for trunk. I suspect you wanted one for gnome-2-20. If this is the case I believe we should hold off on this one until 2.22.
Thanks for the updated patch Scott! I don't see any difference in terms of regular ol' HTML content, so it seems safe to me.
Thanks everyone! Scott, please commit to trunk. The question I have now is if we'd also like to see this for Orca v2.20.1. I know I've asked before, but it's good to get a written record of why we made the decision. I think the decision was that we decided not to do this for gnome-2-20 because the broken hierarchy really only seems to exist for ARIA widgets and ARIA support is only targetted for GNOME 2.22. Right?
Yes, you are correct in that I am only seeing this problem for ARIA widgets. This is why I feel it is best to wait.
committed to truck.
This one seems good to me.
Still seems good post migration. Marked as fixed.