GNOME Bugzilla – Bug 478670
Unshipped files in Subversion trunk
Last modified: 2017-02-09 13:35:24 UTC
With GNOME 2.22 development just now getting under way, this seems like a good time for some fall cleaning. There's quite a few files still living in Subversion trunk that we do not ship in GtkHtml releases. The purpose of this bug is to sort out which of those files we *should* be shipping and which should be deleted. I'm of the opinion that, in general, trunk should only contain what we ship. If we need to resurrect a file down the road we can always fetch it from SCM archives. Keeping dead, unshipped source code files in trunk is especially detrimental to developers because someone will inevitably waste time maintaining them, not realizing or forgetting they're dead. I've lost track of the number of times this has happened to me. Here are the unshipped GtkHtml files currently in Subversion trunk: art/bg1.png capplet/* components/ebrowser/* components/html-editor/persist-file-impl.c components/html-editor/persist-file-impl.h components/html-editor/persist-stream-impl.c components/html-editor/persist-stream-impl.h components/html-editor/resolver-progressive-impl.c components/html-editor/resolver-progressive-impl.h components/html-editor/resolver.c components/html-editor/resolver.h components/http-storage-module/* doc/* } Looks like Gtk-Doc content, should we resurrect this? src/tests/bg.png src/32.png src/gtkhtml-im.c src/gtkhtml-im.h src/gtkhtml-input.c src/gtkhtml-keybinding.c src/gtkhtml-propmanager.c src/gtkhtml-propmanager.h src/html-component.c src/htmlelement.c src/htmlenum.c src/htmlfont.c src/htmlfontface.c src/keybindingssrc.xemacs DEPENDS } DESIGN } We should ship these. MAINTAINERS } MAINTAINERS at least! README.UNDO } README.spell } (I used meld to compare a Subversion checkout against the latest tarball.)
See also bug #478680, bug #478692 and bug #478704.
I think all the files in the list above should be removed, except for those which I've already indicated otherwise. Any thoughts Srini?
I removed the following dead files from trunk. The dates below indicate when the file was removed from Makefile.am, according to source control history. art/bg1.png (Oct 2002) capplet/* (Nov 2002) components/ebrowser/* (Nov 2002) components/html-editor/persist-file-impl.c (Nov 2002) components/html-editor/persist-file-impl.h (Nov 2002) components/html-editor/persist-stream-impl.c (Nov 2002) components/html-editor/persist-stream-impl.h (Nov 2002) components/html-editor/resolver-progressive-impl.c (Feb 2002) components/html-editor/resolver-progressive-impl.h (Feb 2002) components/html-editor/resolver.c (Feb 2002) components/html-editor/resolver.h (Feb 2002) components/http-storage-module/* (Nov 2002) src/tests/bg.png (no history) src/32.png (no history) src/gtkhtml-im.c (Mar 2003) src/gtkhtml-im.h (Mar 2003) src/gtkhtml-input.c (Dec 2000) src/gtkhtml-keybinding.c (Jun 2000) src/gtkhtml-propmanager.c (Nov 2002) src/gtkhtml-propmanager.h (Nov 2002) src/html-component.c (Nov 2002) src/htmlelement.c (Nov 2002) src/htmlfont.c (Dec 2000) src/htmlfontface.c (Sep 2000) src/keybindingssrc.xemacs (Feb 2003)
I ran the following command in gtkhtml/ and found a few more irregularities: comm -3 <(sed -nre 's,^.*[[:space:]]([-a-z]+\.[ch])[[:space:]]*\\?$,\1,p' Makefile.am | sort) <(ls *.h *.c) - htmlenum.c was dead at the time of your cleanup but you didn't remove it. - gtkhtml-propmanager.h is dead. You removed it, but it appears to have been accidentally resurrected in revision 8807. - htmlengine-edit-table.h is listed twice in Makefile.am .
Good catch! Fixed in revision 9146.
GtkHtml is not under active development anymore. Evolution (its main consumer) switched to a WebKit backend a while ago. It is currently unlikely that there will be any further GtkHtml development. Closing this report as WONTFIX as part of Bugzilla Housekeeping (bug 778387) to reflect reality. Please feel free to reopen this bug report in the future if anyone takes the responsibility for active development again.