After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 476786 - whereAmI fails in Firefox menus
whereAmI fails in Firefox menus
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: speech
2.19.x
Other All
: Normal normal
: 2.20.1
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2007-09-14 03:49 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2007-09-26 19:16 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20

Attachments
proposed patch (566 bytes, patch)
2007-09-14 03:52 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2007-09-14 03:49:54 UTC 
Steps to reproduce:

1. Get into any menu within Firefox

2. Use whereAmI

Expected results:  Orca would speak the current location.

Actual results:  Orca says nothing.

Looks like we need to do a NULL check on the string returned by _getObjShortcut(). :-( Patch to follow.
Comment 1 Joanmarie Diggs (IRC: joanie) 2007-09-14 03:52:57 UTC 
Created attachment 95562 [details] [review]
proposed patch

Will, is it okay to check this into trunk now and then commit to the gnome-2-20 branch after code freeze?
Comment 2 Willie Walker 2007-09-14 13:30:18 UTC 
(In reply to comment #1)
> Created an attachment (id=95562) [edit]
> proposed patch
> 
> Will, is it okay to check this into trunk now and then commit to the gnome-2-20
> branch after code freeze?
> 

Yes -- looks like a good thing to do.  Thanks!
Comment 3 Joanmarie Diggs (IRC: joanie) 2007-09-14 14:07:34 UTC 
It's in trunk.
Comment 4 Joanmarie Diggs (IRC: joanie) 2007-09-20 18:23:13 UTC 
It's in the 2-20 branch.  Moving to pending.
Comment 5 Mike Pedersen 2007-09-26 17:58:49 UTC 
Looks good
Comment 6 Joanmarie Diggs (IRC: joanie) 2007-09-26 19:16:19 UTC 
Thanks Mike.  Closing as FIXED.