After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 476411 - Add remove_all to the Iface, implement it in the backends
Add remove_all to the Iface, implement it in the backends
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Passwords, Cookies, & Certificates
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-09-13 03:02 UTC by Cyril Brulebois
Modified: 2007-11-04 23:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed implementation (4.91 KB, patch)
2007-10-01 10:19 UTC, Cosimo Cecchi
committed Details | Review

Description Cyril Brulebois 2007-09-13 03:02:48 UTC
See #148314, comment 16 and comment 25. Concerned files are:
  embed/ephy-password-manager.c
  embed/ephy-password-manager.h

And at first glance:
  mozilla/mozilla-embed-single.cpp
  webkit/webkit-embed-single.cpp
  xulrunner/embed/mozilla-embed-single.cpp
Comment 1 Cosimo Cecchi 2007-10-01 10:19:59 UTC
Created attachment 96453 [details] [review]
proposed implementation

This should work, but to test it properly, we need to commit the patch for bug #148314.
Comment 2 Christian Persch 2007-10-01 17:59:13 UTC
+#if 0
+	/* FIXME if-zeroed because we can't build against XR atm to test it */

no need for this; just commit and I'll fix it if it breaks :)
Comment 3 Cosimo Cecchi 2007-11-04 23:38:09 UTC
Committed to trunk with Xulrunner part uncommented. Closing this as FIXED.

------------------------------------------------------------------------
r7623 | cosimoc | 2007-11-05 00:35:28 +0100 (lun, 05 nov 2007) | 4 lines

Add remove_all_passwords method to EphyPasswordManager and implement it
in Mozilla and XulRunner backends.
Bug #476411.