After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 475956 - Orca sometimes "guesses" index.htm* as the base name for a link in FF3
Orca sometimes "guesses" index.htm* as the base name for a link in FF3
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.19.x
Other All
: Normal normal
: 2.20.1
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2007-09-11 18:42 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2007-09-26 20:35 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20

Attachments
proposed patch (513 bytes, patch)
2007-09-11 18:48 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2007-09-11 18:42:36 UTC 
Steps to reproduce:

1. Tab around balanced.com

Okay so that's just one step. :-)  Anyhoo....

Expected results:  Orca would "guess" the basenames of the images that are serving as links (e.g. FAQ, products, etc.)

Actual results:  Orca speaks/brailles many of those links as "index".

Patch to follow.
Comment 1 Joanmarie Diggs (IRC: joanie) 2007-09-11 18:48:22 UTC 
Created attachment 95380 [details] [review]
proposed patch

If the basename we're about to use starts with "index", guess again. :-)  (In particular, guess the directory in the path that immediately precedes the "index" bit.)

Mike please test.
Comment 2 Mike Pedersen 2007-09-11 18:57:55 UTC 
This works great for me.  I bet this will actually fix quite a few sites.  I'll keep testing though to make sure the patch didn't break any thing else.  Thanks much
Comment 3 Willie Walker 2007-09-11 21:59:39 UTC 
Looks like a good patch for GNOME 2.20.1.  Please submit *after* GNOME 2.20.0 ships.  Thanks!
Comment 4 Joanmarie Diggs (IRC: joanie) 2007-09-12 16:58:30 UTC 
At Mike's request and Will's OK, I've committed this to trunk only.  Leaving this open as a reminder to commit it to the gnome-2-20 branch post freeze.
Comment 5 Willie Walker 2007-09-20 13:41:45 UTC 
Go ahead and commit to both the gnome-2-20 branch and trunk.  Thanks!
Comment 6 Joanmarie Diggs (IRC: joanie) 2007-09-20 18:28:04 UTC 
Was in trunk; just added to the 2-20 branch.  Moving to pending.
Comment 7 Mike Pedersen 2007-09-26 17:58:04 UTC 
This is a big improvement
Comment 8 Joanmarie Diggs (IRC: joanie) 2007-09-26 20:35:25 UTC 
Thanks Mike.  Closing as FIXED.