After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 474897 - rendering problem with latest gtk+
rendering problem with latest gtk+
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
2.11.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2007-09-08 16:54 UTC by Behdad Esfahbod
Modified: 2007-09-10 18:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
shot (87.71 KB, image/png)
2007-09-08 16:58 UTC, Behdad Esfahbod
  Details
patch (950 bytes, patch)
2007-09-10 18:05 UTC, Behdad Esfahbod
committed Details | Review

Description Behdad Esfahbod 2007-09-08 16:54:50 UTC
after updating gtk+ from master, I'm  seeing rendering issues when scrolling in devhelp only.
Comment 1 Behdad Esfahbod 2007-09-08 16:58:29 UTC
Created attachment 95178 [details]
shot
Comment 2 Behdad Esfahbod 2007-09-08 19:10:26 UTC
Only happens when scrolling up.
Comment 3 Richard Hult 2007-09-10 17:33:11 UTC
I did some bisecting and it looks like this commit introduced the problem:

Thu Aug 23 15:32:09 2007  Tim Janik  <timj@imendio.com>

        * gdk/x11/gdkgeometry-x11.c (_gdk_window_process_expose): fix
        X serial handling to cope with wraparounds and maintain referential
        integrity when removing list nodes. based on a patch by Hui Wang,
        fixes #461648.

http://svn.gnome.org/viewcvs/gtk%2B?view=revision&revision=18693

We don't do anything special in devhelp, just embedding gtkmozembed. The special overlay on top might trigger some bug though. I just tried with epiphany and it has the exact same bug.
Comment 4 Behdad Esfahbod 2007-09-10 18:04:56 UTC
The math in the patch is not correct if serial and item->serial are equal.  It should be inverted.  Attaching patch.
Comment 5 Behdad Esfahbod 2007-09-10 18:05:50 UTC
Created attachment 95296 [details] [review]
patch
Comment 6 Behdad Esfahbod 2007-09-10 18:10:51 UTC
Committed after updating to trunk.

2007-09-10  Behdad Esfahbod  <behdad@gnome.org>

        * gdk/x11/gdkgeometry-x11.c (gdk_window_queue),
        (_gdk_window_process_expose): Fix serial number comparison regression
        introduced recently. (#474897)

Comment 7 Richard Hult 2007-09-10 18:14:00 UTC
Thanks, that was a quick turnaround :)

Comment 8 Behdad Esfahbod 2007-09-10 18:17:38 UTC
Yep.  Thanks for doing the hard part of bisecting.

Do you use a git-svn checkout?  How do you handle the build/ subdir that is svn:external?   Last time I tried (two months ago), glib git-svn checkout didn't build because of that.  Thanks.
Comment 9 Emmanuele Bassi (:ebassi) 2007-09-10 18:33:00 UTC
(In reply to comment #8)

> Do you use a git-svn checkout?  How do you handle the build/ subdir that is
> svn:external?   Last time I tried (two months ago), glib git-svn checkout
> didn't build because of that.  Thanks.

I usually just copy it into a git-svn repository from a SVN checkout and then git-ignore it. 

Comment 10 Richard Hult 2007-09-10 18:40:59 UTC
I only have gtk+ in git-svn, and not glib so I don't really get hit by that.
Comment 11 Behdad Esfahbod 2007-09-10 18:49:03 UTC
Thanks.  I'll give it another try.