After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 474543 - NetworkManager should more fully url-quote ESSIDs
NetworkManager should more fully url-quote ESSIDs
Status: RESOLVED DUPLICATE of bug 399292
Product: NetworkManager
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Dan Williams
Dan Williams
Depends on:
Blocks:
 
 
Reported: 2007-09-07 12:49 UTC by Colin Walters
Modified: 2008-02-18 17:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Colin Walters 2007-09-07 12:49:53 UTC 
Hi, object paths cannot have '//', see:
http://dbus.freedesktop.org/doc/dbus-specification.html
Multiple '/' characters cannot occur in sequence. 

So in particular the / needs to be escaped.

+ Trace 161109

Thread NaN (LWP 2148)

  • #0 __kernel_vsyscall
  • #1 *__GI_raise
    at ../nptl/sysdeps/unix/sysv/linux/raise.c line 64
  • #2 *__GI_abort
    at abort.c line 88
  • #3 _dbus_abort
    at dbus-sysdeps.c line 86
  • #4 _dbus_warn_check_failed
  • #5 dbus_message_new_method_call
    at dbus-message.c line 1071
  • #6 nma_dbus_device_update_one_network
    at applet-dbus-devices.c line 630
  • #7 nma_dbus_device_properties_cb
    at applet-dbus-devices.c line 831
  • #8 _dbus_pending_call_complete
    at dbus-pending-call.c line 198
  • #9 complete_pending_call_and_unlock
    at dbus-connection.c line 2170
  • #10 dbus_connection_dispatch
    at dbus-connection.c line 4296
  • #11 message_queue_dispatch
    at dbus-gmain.c line 101
  • #12 IA__g_main_context_dispatch
    at gmain.c line 2061
  • #13 g_main_context_iterate
    at gmain.c line 2694
  • #14 IA__g_main_loop_run
    at gmain.c line 2898
  • #15 IA__gtk_main
    at gtkmain.c line 1144
  • #16 main
    at main.c line 67
  • #17 __libc_start_main
    at libc-start.c line 220
  • #18 _start 






Comment 1


Dan Williams





          2007-12-07 14:59:48 UTC
        



Yeah, the network path escaping logic is still pretty broken :(  It explicitly excludes '/' from being escaped because it's necessary for the dbus object path, and the escapes are performed on the full object path, which is wrong.  The code should only escape the parts of the object path that are potentially unsafe, i.e. the device name and the SSID.






Comment 2


Dan Williams





          2008-02-18 17:12:40 UTC
        




*** This bug has been marked as a duplicate of 399292 ***