GNOME Bugzilla – Bug 474332
"suspicious" code sequence in bseamplifier plugin
Last modified: 2007-09-20 18:15:56 UTC
Please describe the problem: bseamplifier.cc contains this code fragment: case PROP_AUDIO_BALANCE: alevel1 = alevel2 = 100; bse_balance_set (audio_balance, &alevel1, &alevel2); notify ("alevel1"); notify ("alevel2"); break; case PROP_CTRL_BALANCE: alevel1 = alevel2 = 100; bse_balance_set (ctrl_balance, &alevel1, &alevel2); notify ("alevel1"); notify ("alevel2"); break; shouldn't the second case: read like this? case PROP_CTRL_BALANCE: clevel1 = clevel2 = 100; bse_balance_set (ctrl_balance, &clevel1, &clevel2); notify ("clevel1"); notify ("clevel2"); break; This shouldn't have any real significance, as this is a compatibility property, but who knows. Steps to reproduce: 1. 2. 3. Actual results: Expected results: Does this happen every time? Other information:
(In reply to comment #0) > Please describe the problem: > bseamplifier.cc contains this code fragment: > case PROP_CTRL_BALANCE: > alevel1 = alevel2 = 100; > bse_balance_set (ctrl_balance, &alevel1, &alevel2); > notify ("alevel1"); > notify ("alevel2"); > break; > > shouldn't the second case: read like this? > > case PROP_CTRL_BALANCE: > clevel1 = clevel2 = 100; > bse_balance_set (ctrl_balance, &clevel1, &clevel2); > notify ("clevel1"); > notify ("clevel2"); > break; > > This shouldn't have any real significance, as this is a compatibility property, > but who knows. jup, it only matters when reading 0.5.4 files, but it indeed needs fixing, thanks for spotting: 2007-09-20 20:08:16 Tim Janik <timj@gtk.org> * bseamplifier.cc: property_changed(): fixed missing property notifies and compat property handling wrg to audio levels and ctrl_balance, fixes bug #474332.