After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 472377 - Need to fix braille for radio buttons and checkboxes in HTML content
Need to fix braille for radio buttons and checkboxes in HTML content
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: braille
2.19.x
Other All
: Normal normal
: 2.24.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2007-08-31 23:52 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2008-05-27 20:01 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20


Attachments
The Meg Ryan patch (2.87 KB, patch)
2007-09-01 19:41 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2007-08-31 23:52:50 UTC
As indicated on bug #471955, we should have a Gecko-specific generator for radio buttons similar to what we have for checkboxes.

In addition, the current braille generator for checkboxes needs to be modified so that the label comes before the role.
Comment 1 Willie Walker 2007-09-01 07:36:46 UTC
I think the Meg Ryan patch from bug 471955 is good for gnome-2-20 and should be checked into trunk and gnome-2-20.  I realize it doesn't address the indicator/role/label ordering issue, but it does eliminate much redundancy in the label presentation for braille and represents a significant step towards improving usability in this area.

Given that {check,radio}buttons indicators and their labels are separate objects in HTML, but atomic objects in GTK+, I think the indicator/role/label ordering problem for braille might be a tougher nut to crack.  I'm wondering if the ultimate resolution may be to just merely eliminate the rolename.
Comment 2 Joanmarie Diggs (IRC: joanie) 2007-09-01 19:41:32 UTC
Created attachment 94767 [details] [review]
The Meg Ryan patch

Doesn't repeat the labels over and over again.  Radio buttons are now like checkboxes.  Both still need the role and label reversed (or the role removed as Will suggested).
Comment 3 Joanmarie Diggs (IRC: joanie) 2007-09-01 19:51:53 UTC
Meg's been checked in to both trunk and the 2.20 branch. (Yes! Yes! Yes!)
Comment 4 Willie Walker 2007-11-01 18:51:29 UTC
> Radio buttons are now like
> checkboxes.  Both still need the role and label reversed (or the role removed
> as Will suggested).

Mike - what do you think of removing the rolename?  The user will still get the status indicator (e.g., "< >" and "<x>"), allowing them to infer what kind of component this is.
Comment 5 Mike Pedersen 2007-11-01 18:56:17 UTC
Even though the indicators are different I think removing the role would confuse new users.  I would not be in favor of this change.
Comment 6 Joanmarie Diggs (IRC: joanie) 2007-12-11 21:08:38 UTC
As agreed in today's team meeting: Moving this to FUTURE as it's looking like a lot of work for a relatively isolated issue.
Comment 7 Willie Walker 2008-03-11 14:06:30 UTC
First coarse pass at GNOME 2.24 planning.
Comment 8 Joanmarie Diggs (IRC: joanie) 2008-05-27 20:01:25 UTC
As per team meeting, we want to present the labels for radio buttons and checkboxes based on where they appear on the page rather than force them to be consistent with their XUL equivalents.  Therefore, this bug is being closed as FIXED.