After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 471473 - German Tax: UStVa field 45 is missing
German Tax: UStVa field 45 is missing
Status: VERIFIED FIXED
Product: GnuCash
Classification: Other
Component: Reports
git-master
Other All
: Normal normal
: ---
Assigned To: Andreas Köhler
Andreas Köhler
Depends on:
Blocks: 473506
 
 
Reported: 2007-08-29 17:37 UTC by Rolf Leggewie
Modified: 2018-06-29 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add field "45" in txf-de_DE.scm category list (768 bytes, patch)
2007-09-02 17:13 UTC, Christian Stimming
committed Details | Review
diff for src/tax/us/txf-de_DE.scm (1.54 KB, patch)
2007-09-04 13:22 UTC, Rolf Leggewie
none Details | Review
updated diff for txf-de_DE.scm (7.60 KB, patch)
2007-09-04 13:55 UTC, Rolf Leggewie
committed Details | Review

Description Rolf Leggewie 2007-08-29 17:37:49 UTC
Please describe the problem:
Hi,

this is of no relevance for international users and only concerns experimental code from Christian Stimming.  Thus, I will keep the remainder of this report in German.

Ich bin gerade dabei, gnucash als Steuersoftware für mich nutzbar zu machen (vgl. bug 433428 und http://linuxwiki.de/GnuCash/EuerGc).  Dabei ist mir aufgefallen, daß es für das Feld 45 in der Umsatzsteuervoranmeldung ("Im Inland nicht steuerbare Umsätze") zwar ein Konto im SKR04 von Frank Ellenberger, aber keine Möglichkeit zur Verknüpfung mit dem Steuer-Bericht gibt.  Dieses fehlt unter "Bearbeiten - Steuerrelevante Optionen".  

Wenn ich wüßte, wo das festgelegt wird, würde ich einen Patch beifügen.  Ich bin mir sicher, es gibt noch weitere, kleine Fehler.

Mit freundlichen Grüßen

Rolf

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Christian Stimming 2007-08-31 10:11:21 UTC
(Rolf: It's okay if you write in German, but I'll answer in English anyway. I hope this isn't an issue.) 

This concerns *all* fields of the tax declaration, not only the field 45, right? In that case, did you already compile with --enable-locale-specific-tax? If yes, you should be able to insert this link between field 45 and the account in the "Steuerrelevante Einstellungen". Or is this dialog missing something?
Comment 2 Rolf Leggewie 2007-09-02 09:45:56 UTC
(In reply to comment #1)
> This concerns *all* fields of the tax declaration, not only the field 45,
> right?

No, so far I only spotted field 45. 

> In that case, did you already compile with --enable-locale-specific-tax?

Take a look at http://linuxwiki.de/GnuCash/EuerGc ;-)  The answer is yes.

> in the "Steuerrelevante Einstellungen". Or is this dialog missing something?

The dialog is not missing, just the field 45.
Comment 3 Christian Stimming 2007-09-02 17:13:29 UTC
Created attachment 94816 [details] [review]
Add field "45" in txf-de_DE.scm category list

Ok, so your bugreport simply said the category listing is missing the "45" entry, but all other entries are fine. The attached patch adds that category. Does that fix your issue? If yes, I'll apply to SVN. (Also, this should show you how you could add more categories yourself in case more are missing.)
Comment 4 Christian Stimming 2007-09-02 19:43:03 UTC
Applied this patch as SVN r16483.
Comment 5 Rolf Leggewie 2007-09-03 14:15:58 UTC
verified fixed.  Thanks.
Comment 6 Rolf Leggewie 2007-09-04 12:34:59 UTC
reopening.  There are several mistakes in this list.  I will need assistance from Christian to fix them right.

Here is what I looked at "grep cons src/tax/us/txf-de_DE.scm |sort|less".  The following becomes clear.

a) K45 is in that file twice now.  Not sure why it was not displayed correctly from the GUI.  Christian can you please investigate?
b) the old entry for K45 is wrong.  It mixes some information from K60
c) K60 is missing
d) K52, K73, K84, K53, K74 and K85 are missing
Comment 7 Rolf Leggewie 2007-09-04 12:43:10 UTC
(In reply to comment #6)
> a) K45 is in that file twice now.  Not sure why it was not displayed correctly
> from the GUI.

The reason is quite simply that the other, old K45 is incorrectly identified as expense.

Is there any reason *not* to sort the cons-entries?

I will rework the file a bit and attach a patch later.
Comment 8 Christian Stimming 2007-09-04 12:53:04 UTC
(sigh. Please file new bugs for new issues. Adding new issues to old bugs, like
here, makes it very confusing to read the whole report. Thanks.)

K45 used to be listed under "expense" category. You expected it in the "income"
category but for whatever reason 3 years ago I had the impression it should be
listed in the "expense" category. If you think it should be listed under one of
them, please say so. If you think the division into these two categories should
be thrown out altogether, please say so, too, but that will probably require
much more work.

As for the other entries: Well, if there are missing entries, please give all
the details that should be listed there. 

I don't know those details, and frankly, I don't want to spend any new work in
that area anymore. It is fine for me to spend some time explaining to you what
I did, and applying ready-made patches is fine, too, but I won't do anything
more than that. Thanks, and good luck!

> Is there any reason *not* to sort the cons-entries?

No.

> I will rework the file a bit and attach a patch later.

Good.
Comment 9 Rolf Leggewie 2007-09-04 13:22:47 UTC
Created attachment 94924 [details] [review]
diff for src/tax/us/txf-de_DE.scm

* sorted entries
* added some fields
* removed some errors

I'd be surprised if the file is error-free now.  Hopefully, I did not add more errors than I removed ;-)
Comment 10 Rolf Leggewie 2007-09-04 13:55:30 UTC
Created attachment 94932 [details] [review]
updated diff for  txf-de_DE.scm
Comment 11 Christian Stimming 2007-09-04 19:34:24 UTC
Committed as r16505. Thanks for the patch.
Comment 12 Rolf Leggewie 2007-09-05 06:53:42 UTC
(In reply to comment #8)
> (sigh. Please file new bugs for new issues.

I think it is debatable (although rather fruitless) whether this is a new issue.  For me this bug had come to be about src/tax/us/txf-de_DE.scm, thus not a new issue.

> If you think it should be listed under one of
> them, please say so. If you think the division into these two categories should
> be thrown out altogether, please say so, too, but that will probably require
> much more work.

I am learning this myself here, providing patches along the way.  Many of the bug reports I opened in the past few days are really more of a todo list and a reminder to myself about issues I have come across.  I don't intend to sit back and expect you to fix them.  It would certainly be nice if you helped me a bit here and there, your time permitting.

BTW, it might be that src/tax/us/txf-de_DE.scm is not correct even now (I think it is not).  And it might indeed be that the income-expense dichotomy is not sufficient.  I will let you know once I find out more.

Thank you for providing this feature.  I hope that rather than "sigh"ing you can soon enjoy the fact that after all somebody *is* using your work and hopefully improving the areas around it to make it actually useable and useful to a wider audience.
Comment 13 John Ralls 2018-06-29 21:47:24 UTC
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=471473. Please update any external references or bookmarks.