After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 471389 - NTLM broken in libsoup head
NTLM broken in libsoup head
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: HTTP Transport
2.2.x
Other Linux
: Normal blocker
: ---
Assigned To: Dan Winship
Dan Winship
Depends on:
Blocks:
 
 
Reported: 2007-08-29 01:40 UTC by Dan Winship
Modified: 2007-09-24 00:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to fix NTLM (514 bytes, patch)
2007-09-12 13:27 UTC, Dan Winship 		none Details | Review

Description Dan Winship 2007-08-29 01:40:55 UTC 
Varadhan reports that NTLM is broken in libsoup head:

  Basically, the "Authorization" header gets removed when lookup_auth()
  fails - as soup_message_set_auth() is called with a NULL auth parameter
  that removes this header and because of this, in the response,
  "WWW-Authenticate" doesn't contain a valid NTLM Challenge token.

  To my limited knowledge, I think this is a regression because of
  http://svn.gnome.org/viewcvs/libsoup/trunk/libsoup/soup-session.c?r1=904&r2=922

However, later he said that reverting that commit does not seem to fix it.

We can't have a new release of libsoup until this is figured out. And I have
no way of testing NTLM any more.
Comment 1 Dan Winship 2007-09-11 15:29:15 UTC 
OK, I have an Exchange server to test against now, and reverting that patch *does* fix the bug.

However, we're in hard code freeze for GNOME 2.20 right now (and I'm not going to request a break since there hasn't been a HEAD release of libsoup since 2.18 so none of the rest of the new code is especially tested yet either). So GNOME 2.20 will ship with libsoup 2.2.100 just like 2.18 did. A new release will go out before 2.20.1 in October.
Comment 2 Dan Winship 2007-09-12 13:27:40 UTC 
Created attachment 95437 [details] [review]
patch to fix NTLM

Varadhan, can you try this out?
Comment 3 Dan Winship 2007-09-24 00:54:26 UTC 
fixed in HEAD. Will go out in 2.2.101 for GNOME 2.20.1