After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 469912 - Can't open ICNS icons
Can't open ICNS icons
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: image viewer
unspecified
Other Linux
: Normal normal
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-08-24 14:18 UTC by Bastien Nocera
Modified: 2018-05-31 13:41 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Bastien Nocera 2007-08-24 14:18:05 UTC
Testing the code in bug 395738, I couldn't load the files in EOG.

EOG only supports images for which the loader has incremental load support. This isn't the case for the icns loader.
Comment 1 Lucas Rocha 2007-09-03 20:28:58 UTC
Isn't it because of what you mention in comment #8 of bug #395738? EOG uses incremental image loading...
Comment 2 Bastien Nocera 2007-09-03 20:32:42 UTC
Yes it is. EOG should have some fallback code though.
Comment 3 Felix Riemann 2007-12-11 13:48:01 UTC
I tend to say that this is sometheing GdkPixbufLoader should do for me transparently.
Theoretically I shouldn't have to implement workarounds for a specific loaders problems, which would remove quite some usefulness from GdkPixbufLoader in my eyes. 
Comment 4 Bastien Nocera 2007-12-11 14:38:58 UTC
(In reply to comment #3)
> I tend to say that this is sometheing GdkPixbufLoader should do for me
> transparently.
> Theoretically I shouldn't have to implement workarounds for a specific loaders
> problems, which would remove quite some usefulness from GdkPixbufLoader in my
> eyes. 

No, EOG simply doesn't support non-incremental loading. It's far from a work-around to support it, and it could hit any loader (a few loaders go out of their way to mimic incremental loading, which is not where the work should be done).
Comment 5 Felix Riemann 2008-01-16 11:41:34 UTC
(In reply to comment #4)
> No, EOG simply doesn't support non-incremental loading. It's far from a
> work-around to support it, and it could hit any loader (a few loaders go out of
> their way to mimic incremental loading, which is not where the work should be
> done).
> 

But that would mean that every GdkPuxbufLoader-using application would have to implement the GdkPixbuf-fallback (that might be the better word here than "workaround) to be really on the save side, as theoretically every loader could be non-incremental (even it is now; you might never know).
This doesn't make it appealing to use GdkPixbufLoader as you still need to implement the fallback. You could as well just use the fallback alone without fiddling with GdkPixbufLoader.

Additionally I shouldn't have to know about the loaders, that's what GdkPixbuf and GdkPixbufLoader are there for.

But maybe I just want to use GdkPixbufLoader for things it wasn't designed for.
Comment 6 Rodrigo Silva 2013-04-29 22:57:15 UTC
5 years later, any news on this?
Comment 7 Felix Riemann 2018-05-31 13:41:46 UTC
This seems to have been fixed in gdk-pixbuf in the meantime by bug 629474.