GNOME Bugzilla – Bug 469083
[pending] Refactor Gecko.py's getContainingRole() to take a list
Last modified: 2008-07-22 19:32:31 UTC
As indicated here http://bugzilla.gnome.org/show_bug.cgi?id=466764#c6 and in subsequent comments, it would be handy if the second parameter of getContainingRole() was a list of roles rather than a single role.
This work probably should be done in conjunction with the work on bug 460735, since both are seeing a need to get an ancestor/container with a specific role. See also http://bugzilla.gnome.org/show_bug.cgi?id=460735#c10.
Created attachment 98974 [details] [review] take 1 Now that bugzilla's once again back up.... This seems to get the job done and passes the regression-test, pychecker, and pyflakes tests. However pylint complained that having an empty list as a default argument (which is what I used for the stopRoles) was "dangerous." Is that a valid complaint?
Looks great. Please commit! Thanks!
> This seems to get the job done and passes the regression-test, pychecker, and > pyflakes tests. However pylint complained that having an empty list as a > default argument (which is what I used for the stopRoles) was "dangerous." Is > that a valid complaint? Sorry - missed this part. I say take the default value out for now. Thanks!
Created attachment 98978 [details] [review] take 2: no default value for stopRoles Sounds good. Patch committed.
Feel free to close. Thanks!
Done. Thanks!