GNOME Bugzilla – Bug 468765
[verified] Orca does not provide access to shortcuts for FF3 or Thunderbird menu items
Last modified: 2008-07-22 19:28:24 UTC
Steps to reproduce: 1. Launch Firefox or Thunderbird 2. Navigate to a menu that has an associated shortcut (e.g. New Window in the File menu) 3. Use whereAmI Expected results: In steps 2 and 3, Orca would speak and display the associated shortcut (e.g. Control N) along with the name of the menu item. Actual results: Orca just speaks and displays only the menu item's name.
I'm seeing the shortcuts exposed in Accerciser. I just need to figure out why we're not handling it correctly. It's 4 AM. I'll get on this tomorrow (I mean today, but later :-) ).
Created attachment 94346 [details] [review] proposed patch getAcceleratorAndShortcut() assumes menu items have three bindings. Failing that, we are setting fullShortcut to bindingStrings[0] and accelerator to an empty string. In Firefox and Thunderbird, we seem to have two bindings. The first one is empty (yeah, I know) and the second one contains the accelerator. Rather than OYAM (override yet another method) in Gecko.py, I thought we could do the attached. Will, what do you think?
(In reply to comment #2) > Created an attachment (id=94346) [edit] > proposed patch > > getAcceleratorAndShortcut() assumes menu items have three bindings. Failing > that, we are setting fullShortcut to bindingStrings[0] and accelerator to an > empty string. In Firefox and Thunderbird, we seem to have two bindings. The > first one is empty (yeah, I know) and the second one contains the accelerator. > Rather than OYAM (override yet another method) in Gecko.py, I thought we could > do the attached. Will, what do you think? > Looks good to me. While you're at this, can you also flag the "space" thing a couple lines down for translation? We already have a "space" defined in chnames.py, so I think we're good with not introducing a string change: So, go from: # If the accelerator string includes a Space, make sure we speak it. # if accelerator.endswith(" "): accelerator += "space" to: # If the accelerator string includes a Space, make sure we speak it. # if accelerator.endswith(" "): # Translators: this is the spoken word for the space character # accelerator += _("space")
Created attachment 94380 [details] [review] flag "space" for translation Thanks Will. Flagged and committed this version to both trunk and the 2-20 branch. Changing the status to pending.
Just caught a typo in "accelerator" and checked in corrections to both trunk and the 2-20 branch. Sorry!!
Works great! thanks
Thanks Mike! Closing as FIXED.