After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 468229 - bsewavetool global short options considered harmful
bsewavetool global short options considered harmful
Status: RESOLVED FIXED
Product: beast
Classification: Other
Component: tools
SVN trunk
Other Linux
: Normal normal
: m0.7
Assigned To: Beast Maintainers
Beast Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-08-19 16:00 UTC by Stefan Westerfeld
Modified: 2007-08-23 13:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch which cleans up options accordingly (7.54 KB, patch)
2007-08-19 16:16 UTC, Stefan Westerfeld
accepted-commit_now Details | Review

Description Stefan Westerfeld 2007-08-19 16:00:23 UTC
Since all bsewavetool commands come with different options, which may or may not be short options, Tim and I discussed that its better to avoid short global options where possible, so that clashes with short command options can be avoided.

The only exceptions should be -o -h and -v, which are common practice elsewhere.
Comment 1 Stefan Westerfeld 2007-08-19 16:16:11 UTC
Created attachment 93941 [details] [review]
Patch which cleans up options accordingly

* this is not backward compatible of course, so scripts will have to be adapted
* I took the opportunity to fix oggenc -Q => -q
* I renamed the variables so that they match the actual option names, too
Comment 2 Tim Janik 2007-08-22 12:06:42 UTC
(In reply to comment #1)
> Created an attachment (id=93941) [edit]
> Patch which cleans up options accordingly
> 
> * this is not backward compatible of course, so scripts will have to be adapted
> * I took the opportunity to fix oggenc -Q => -q
> * I renamed the variables so that they match the actual option names, too 

thanks, the patch looks good, please apply.
Comment 3 Stefan Westerfeld 2007-08-23 13:19:13 UTC
Committed.

Thu Aug 23 15:17:57 2007  Stefan Westerfeld  <stefan@space.twc.de>

        * tools/bsewavetool.cc: Replaced global -k option by --skip-errors,
        global -q option by --silent and oggenc -Q <n> by oggenc -q <n>. The
        idea behind the switch is to avoid global short options where possible
        to minimize collisions with command options now and in the future.
        Fixes #468229.