GNOME Bugzilla – Bug 468229
bsewavetool global short options considered harmful
Last modified: 2007-08-23 13:19:13 UTC
Since all bsewavetool commands come with different options, which may or may not be short options, Tim and I discussed that its better to avoid short global options where possible, so that clashes with short command options can be avoided. The only exceptions should be -o -h and -v, which are common practice elsewhere.
Created attachment 93941 [details] [review] Patch which cleans up options accordingly * this is not backward compatible of course, so scripts will have to be adapted * I took the opportunity to fix oggenc -Q => -q * I renamed the variables so that they match the actual option names, too
(In reply to comment #1) > Created an attachment (id=93941) [edit] > Patch which cleans up options accordingly > > * this is not backward compatible of course, so scripts will have to be adapted > * I took the opportunity to fix oggenc -Q => -q > * I renamed the variables so that they match the actual option names, too thanks, the patch looks good, please apply.
Committed. Thu Aug 23 15:17:57 2007 Stefan Westerfeld <stefan@space.twc.de> * tools/bsewavetool.cc: Replaced global -k option by --skip-errors, global -q option by --silent and oggenc -Q <n> by oggenc -q <n>. The idea behind the switch is to avoid global short options where possible to minimize collisions with command options now and in the future. Fixes #468229.