GNOME Bugzilla – Bug 468040
unimplemented actions GoBack/GoForward
Last modified: 2018-05-22 13:17:50 UTC
** (evince:6066): WARNING **: Unimplemented named action: GoBack, please post a bug report in Evince bugzilla (http://bugzilla.gnome.org) with a testcase. ** (evince:6066): WARNING **: Unimplemented named action: GoForward, please post a bug report in Evince bugzilla (http://bugzilla.gnome.org) with a testcase. Testcase: http://www.blackhat.com/presentations/bh-europe-06/bh-eu-06-biondi/bh-eu-06-biondi-up.pdf and click on the circle icons on the right bottom of the pages.
I tried to knock up a patch to implement this however I ran into a couple of problems. The ev_window_cmd_edit_find_next/ev_window_cmd_edit_find_previous functions only work when the find is active. This is only the case when the search bar at the bottom is visible. Clicking the body of the document causes the search bar to be hidden and then the find cancelled and hence the actions cannot be invoked. To me it seems that the clicking off to hide the find bar is the correct behaviour so it would seem like the way to implement this would be to remember the details of the last search and use that. But this has the disadvantage that its not clear what is happening when the user does this. So perhaps it would be a good idea to pop up the search footer. Ooh. Uhm. ;-) I tried to implement this with the attached patch but I never get past the hits on the one page. Also it has an annoying flicker.
Created attachment 93932 [details] [review] Attempted idea at a patch
thanks for the patch, well another standing one is about find_next/find_prev. Just give me some time to review them both.
hmm, it seems that GoBack and GoForward options have nothing to do with searching, but with history. What acroread does is going to the next and previos pages in the history stack.
Heh. I was comparing with what xpdf was doing (I think, I cannot really recall ...)
*** Bug 563631 has been marked as a duplicate of this bug. ***
*** Bug 588116 has been marked as a duplicate of this bug. ***
so GoForward and GoBack in acroread do seem to follow the history... however, history is implemented differently, as they add a page to the history whenever there is a page change, while we add it only when the new page to old page distance is larger than one.
*** Bug 660106 has been marked as a duplicate of this bug. ***
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/evince/issues/43.