After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 467883 - enable_folder_tree() assumes folder is always selected
enable_folder_tree() assumes folder is always selected
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.12.x
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
: 425093 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-08-18 06:17 UTC by Matthew Barnes
Modified: 2013-09-13 00:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for evolution (1.63 KB, patch)
2007-08-18 06:18 UTC, Matthew Barnes 		committed Details | Review
Patch for evolution-data-server (2.59 KB, patch)
2007-08-18 06:19 UTC, Matthew Barnes 		committed Details | Review

Description Matthew Barnes 2007-08-18 06:17:10 UTC 
Forwarding from a downstream bug:
http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=253348

In mail-component.c, enable_folder_tree() calls em_folder_tree_get_selected_uri() and assumes the result is non-NULL.  This can lead to crashes like the one reported downstream.
Comment 1 Matthew Barnes 2007-08-18 06:18:07 UTC 
Created attachment 93883 [details] [review]
Patch for evolution

This patch hardens the enable_folder_tree() logic.
Comment 2 Matthew Barnes 2007-08-18 06:19:19 UTC 
Created attachment 93884 [details] [review]
Patch for evolution-data-server

I also added some argument checks to various camel-url functions.
Comment 3 Srinivasa Ragavan 2007-08-20 05:53:20 UTC 
bug #467559 is also the same thing. It has a patch committed against this bug. I like your patch better. You may have to rework a bit to get it in. Go ahead and commit it your way.
Comment 4 Matthew Barnes 2007-08-20 15:02:39 UTC 
Committed to trunk.

Evolution - Revision 34047
Evolution-Data-Server - Revision 7978

Thanks for the quick review, Srini.
Comment 5 Frederic Crozat 2007-10-02 09:03:59 UTC 
*** Bug 425093 has been marked as a duplicate of this bug. ***