After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 466870 - 1.9.2 does not build
1.9.2 does not build
Status: RESOLVED FIXED
Product: goobox
Classification: Other
Component: player
1.9.x
Other Linux
: Normal normal
: ---
Assigned To: Goobox Maintainers
Goobox Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-08-15 07:09 UTC by Götz Waschk
Modified: 2008-09-04 07:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build with new scsi/sg.h header (703 bytes, patch)
2007-08-28 10:26 UTC, Götz Waschk
none Details | Review

Description Götz Waschk 2007-08-15 07:09:39 UTC
This is on Mandriva Cooker i586:

g++ -DHAVE_CONFIG_H -I. -I.. -I.. -I.. -DGOO_PREFIX=\"/usr\" -DGOO_SYSCONFDIR=\"/etc\" -DGOO_DATADIR=\"/usr/share\" -DGOO_LIBDIR=\"/usr/lib\" -DGLADEDIR=\""/usr/share/goobox/glade"\" -DGOO_GLADEDIR=\""/usr/share/goobox/glade"\"  -pthread -DORBIT2=1 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/libgnome-2.0 -I/usr/include/orbit-2.0 -I/usr/include/gconf/2 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/libbonobo-2.0 -I/usr/include/bonobo-activation-2.0 -I/usr/include/libgnomeui-2.0 -I/usr/include/libart-2.0 -I/usr/include/gnome-keyring-1 -I/usr/include/libbonoboui-2.0 -I/usr/include/libgnomecanvas-2.0 -I/usr/include/libxml2 -I/usr/include/gail-1.0 -I/usr/include/gnome-vfs-module-2.0 -I/usr/include/libglade-2.0 -I/usr/include/gstreamer-0.10   -I/usr/include/gtk-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/libpng12       -O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 -fexceptions -fomit-frame-pointer -march=i586 -mtune=generic -fasynchronous-unwind-tables -MT dvd_plus_rw_utils.o -MD -MP -MF .deps/dvd_plus_rw_utils.Tpo -c -o dvd_plus_rw_utils.o dvd_plus_rw_utils.cpp
In file included from dvd_plus_rw_utils.cpp:37:
transport.hxx: In member function 'unsigned char& Scsi_Command::operator[](size_t)':
transport.hxx:117: error: 'SG_FLAG_LUN_INHIBIT' was not declared in this scope
transport.hxx: In member function 'int Scsi_Command::transport(Direction, void*, size_t)':
transport.hxx:152: error: pointer of type 'void *' used in arithmetic
transport.hxx:152: error: 'void*' is not a pointer-to-object type
transport.hxx:152: error: pointer of type 'void *' used in arithmetic
transport.hxx:152: error: 'void*' is not a pointer-to-object type
transport.hxx:152: error: pointer of type 'void *' used in arithmetic
transport.hxx:152: error: 'void*' is not a pointer-to-object type
transport.hxx:152: error: pointer of type 'void *' used in arithmetic
transport.hxx:152: error: 'void*' is not a pointer-to-object type
transport.hxx:152: error: pointer of type 'void *' used in arithmetic
transport.hxx:152: error: 'void*' is not a pointer-to-object type
transport.hxx:153: error: pointer of type 'void *' used in arithmetic
transport.hxx:153: error: 'void*' is not a pointer-to-object type
transport.hxx:153: error: pointer of type 'void *' used in arithmetic
transport.hxx:153: error: 'void*' is not a pointer-to-object type
transport.hxx:153: error: pointer of type 'void *' used in arithmetic
transport.hxx:153: error: 'void*' is not a pointer-to-object type


I'm using glibc 2.6.1, gcc 4.2.1 and the GNOME 2.19 platform.
Comment 1 Paolo Bacchilega 2007-08-15 18:36:31 UTC
on my system the SG_FLAG_LUN_INHIBIT macro is defined in /usr/include/scsi/sg.h, can you check if this is the same for you ?
Comment 2 Götz Waschk 2007-08-15 23:36:07 UTC
No, I don't have that macro. But I have SG_FLAG_UNUSED_LUN_INHIBIT.
Comment 3 Funda Wang 2007-08-17 11:21:31 UTC
It seems glibc 2.6.1 changed this one.
Comment 4 Götz Waschk 2007-08-28 10:26:36 UTC
Created attachment 94494 [details] [review]
build with new scsi/sg.h header

This makes goobox build with the new scsi/sg.h header from glibc 2.6.1. The SG_FLAG_LUN_INHIBIT apperantly was renamed and the type of sbp has changed to void *
Comment 5 Felix Riemann 2007-09-26 10:55:22 UTC
Are you sure this has changed?

glibc-2.6.1 still has the old SG_FLAG_LUN_INHIBIT on my Gentoo install.
Fedora's 2.6.90 headers [1] and glibc's CVS [2] too.

Or am I looking at the wrong sources?

[1] http://fr2.rpmfind.net/linux/RPM/fedora/devel/i386/glibc-headers-2.6.90-15.i386.html
[2] http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/sysdeps/unix/sysv/linux/scsi/sg.h?rev=1.7&content-type=text/x-cvsweb-markup&cvsroot=glibc
Comment 6 Götz Waschk 2007-09-26 20:00:39 UTC
to #5: That's right. But in Mandriva's glibc package, the headers are replaced by the files from the kernel package (2.6.22.3mdv). Looks like the main Linux kernel has this too:
http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.22.y.git;a=blob;f=include/scsi/sg.h;h=519c49a0fc11decf664e6d676f1dab8580169236;hb=6460e75a104d10458817d2f5b2fbff775bf0b43a
Comment 7 Götz Waschk 2008-09-04 07:31:17 UTC
This is fixed in goobox 2.0.0.