GNOME Bugzilla – Bug 46664
metadata code ignores CORBA-reported errors
Last modified: 2006-10-03 15:09:05 UTC
The new metadata code in nautilus-directory-metafile.c ignores any errors which are reported by the CORBA_environment. ------- Additional Comments From engber@eazel.com 2001-02-20 10:25:35 ---- Also in nautilus-metfile.c. There are FIXMEs in both files about this. ------- Bug moved to this database by unknown@bugzilla.gnome.org 2001-09-09 21:00 ------- The original reporter (engber@eazel.com) of this bug does not have an account here. Reassigning to the exporter, unknown@bugzilla.gnome.org. The original owner (engber@eazel.com) of this bug does not have an account here. Reassigning to the default owner of the component, nautilus-maint@bugzilla.gnome.org.
Changing to "old" target milestone for all bugs laying around with no milestone set.
Adding GNOME2 keyword as this is still relevant. See bug #73456. What should each function do when an error is encountered?
Damon: what's the impact here? more possible crashes, I take it? but mostly hypothetical ones that aren't happening?
It means that if an error occurs trying to communicate between Corba components, there is a fairly high chance of a crash. But I'd guess that if there is a communication error nautilus is in pretty bad shape anyway, so I don't think this is too serious.
Removing the milestone. The code will probably be freed from CORBA and/or replaced by a non-Nautilus specific solution.
A crash happened here shortly after a nautilus -q; the returned corba_value contained bogus data.
Created attachment 72640 [details] [review] Proposed patch This bug actually seems to do much harm under some circumstances.
Raising priority/severity.
There seems to be a bug in the patch causing asserts: http://mail.gnome.org/archives/nautilus-list/2006-September/msg00032.html
I committed it after changing g_assert (found || error != NULL); into g_assert (!found || error != NULL); in nautilus-metafile.c:corba_register_monitor() Sorry for this slip of the pen, yet another in a long series :/.
Closing, fixed.
Created attachment 72807 [details] [review] Committed Patch (to HEAD) For the sake of clarity, I'm obsoleting the old attachment 72640 [details] [review], replacing it with a new patch which has the changes specified in comment 10.
Thanks for the patch, Manny! I'm backporting this for https://bugzilla.novell.com/show_bug.cgi?id=209234