GNOME Bugzilla – Bug 466499
Missing mnemonics in editing pop account settings
Last modified: 2013-09-13 00:58:04 UTC
Missing mnemonics for 1) Leave messages on server 2) Delete after [x] days. 3) Disable support for all POP3 extensions. In Preferences edit pop mail account -> Receiving Options. Other information: Read the following before going ahead and assigning mnemonics. http://developer.gnome.org/projects/gup/hig/2.0/input-keyboard.html#choosing-access-keys
Created attachment 93623 [details] Screenshot of missing mnemonics. Attaching screen shot of missing mnemonics.
Created attachment 99890 [details] [review] The EDS half of the patches Attached are the two patches to fix the bug at http://bugzilla.gnome.org/show_bug.cgi?id=466499 patch4_ESD.patch needs to be applied to the data server sources, while patch4_evolution.patch is applied to the evolution source I used http://mail.gnome.org/archives/evolution-patches/2004-November/msg00209.html for the evolution half of the patch, and it might be helpful to open a bug for this patch at some point.
Created attachment 99891 [details] [review] The evolution half of the patches Attached are the two patches to fix the bug at http://bugzilla.gnome.org/show_bug.cgi?id=466499 patch4_ESD.patch needs to be applied to the data server sources, while patch4_evolution.patch is applied to the evolution source I used http://mail.gnome.org/archives/evolution-patches/2004-November/msg00209.html for the evolution half of the patch, and it might be helpful to open a bug for this patch at some point.
David, I think the first patch, similar work has to be done for other providers too. Only then it is complete. You have done for pop3 alone. The evolution patch g_object_set_data is wrong. 'active' should be a state and not a data. you can use gtk_check* calls to set the active state. But this is definitely wrong.
Created attachment 99964 [details] [review] Updated patch for the evolution half I have updated the evolution half of the patch to use gtk_toggle_button_set_active (There didn't seem to be a gtk_checkbutton specific set_active function) As for the other providers, IMAP in specific is being worked on by klossalex for http://bugzilla.gnome.org/show_bug.cgi?id=347317 - However I will fix the other providers.
Created attachment 99965 [details] [review] Updated patch for the EDS half I have now fixed POP, NNTP and local providers. (To clarify, the reason I am leaving IMAP is because another GHOP participant is fixing that bug, and I'd rather not have them waste their time)
David, just two more suggestions. 1. in the evolutoin patch you have to leave the existing g_object_set_data as it is. That is necessary. 2. In the EDS patch, the letter you gotto choose to be unique and easy to identify. For example, use the _S in the first character than some where in the middle. Just rework on that aspect. It is all fine to commit other wise. Just look at the HACKING file for spacing, brace positions etc. It needs to match what the rest of the file looks like. Also, patch should have a ChangeLog. Thanks for your patch.
Created attachment 99987 [details] [review] Evolution half of the patch, another update Added a changelog and left in the old g_object_set_data. Also fixed some spacing issues
Created attachment 99988 [details] [review] The EDS part of the patch, another update Added a changelog to the patch and changed some mnemonics to more appropriate letters
Add bug reference to ChangeLog, please. eds patch: Even the patch from Bug 329578 is not committed yet, it uses "t" as mnemonic, please try to choose other letter. Thanks. evo patch: Looks good to commit to trunk, but has no meaning without the eds part.
Created attachment 100132 [details] [review] Yet another update to the EDS half Yet another update to the EDS half - adds bug references to changelogs and fixes mnemonic clash
evo patch, I only fixed warning: em-account-editor.c:1905: warning: passing argument 1 of 'gtk_toggle_button_set_active' from incompatible pointer type eds patch, ok. Both are able to hit trunk.
eds part committed to trunk. Committed revision 8267. evo part committed to trunk. Committed revision 34645.